In the permissions page, the documentation for "Add content and child pages to books" isn't as clear as it should be. It should have a short description stating that without this, users won't be able to manipulate book hierarchies. We should better describe that permission in order to help people use the book module correctly.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | new_improved_label_1866932.patch | 657 bytes | anul |
| #17 | new_improved_label_1866932.patch | 657 bytes | anul |
| #13 | improved_label_1866932_#11.patch | 657 bytes | anul |
| #9 | improved_label_1866932.patch | 653 bytes | anul |
| #6 | add_description_permission-1866932-2.patch | 612 bytes | anul |
Comments
Comment #1
benelori commentedAdded description for 'add content to books' permission on the permission page.
Comment #2
benelori commentedComment #3
jhedstromThis would need to be for 8.1 I think since it adds strings.
Comment #5
anul commentedgit apply -v add_description_permission-1866932-1.patch
Checking patch core/modules/book/book.module...
error: while searching for:
),
'add content to books' => array(
'title' => t('Add content and child pages to books'),
),
'access printer-friendly version' => array(
'title' => t('View printer-friendly books'),
error: patch failed: core/modules/book/book.module:89
error: core/modules/book/book.module: patch does not apply
When i applied this patch it couldn't find the particular line of code inside book.module
So this #1 patch is out dated now..
Comment #6
anul commentedAdded New Patch for the description to add to permissions page.
Comment #7
hesnvabr commentedTested and reviewed this patch it looks fine.
Comment #8
xjmI actually don't think this is the best change. In general, we should try to label things clearly enough so that they do not need descriptions, because added text increases the burden on the user and degrades user experience. A lot of work has been done in Drupal 7 and 8 to remove descriptions.
If we want to improve this, let's see if we can improve the title instead to contain the needed information. Once we've a proposal for that, we can look at a usability review of the proposed text.
Comment #9
anul commentedI totally agree on the point mentioned in the comment #8. So here is the improved solution for this with the improved label. I am adding a new patch.
Comment #10
hesnvabr commentedI applied this patch it looks fine.I think conditions/criteria are also fulfilled.
Comment #11
xjmThanks, I think that's a much better direction!
I think it could be a little clearer:
Add content and child pages to books, and manage their hierarchies.How about that?
Comment #12
anul commentedYes Awesome!!
Thank You @xjm.
"manage their hierarchies" seems more standardised then "to manipulate hierarchies".
Comment #13
anul commentedSo here is the new patch i have added for more improved label.
Comment #15
naveenvalechaThis seems to be the documentation change. correct me if I'm wrong.
Comment #17
anul commentedAdding a new patch as previous one failed testing.
Comment #18
anul commented@naveen yes this is related to documentation of Book Module.
Comment #20
anul commentedComment #22
hesnvabr commentedAccording to that #11 this patch is almost fulfill the requirements.
Comment #24
xjmGreat, thanks @Anul! Committed 8c04cd1 and pushed to 8.2.x. This is a good usability improvement.
By the way, "Documentation" is generally reserved for our in-code and handbook documentation that does not affect Drupal functionally, whereas this one is a user interface string. So retroactively moving it back to the book module for that reason.
Comment #28
hesnvabr commented