Title says it all. Please remove the connect option from line 34 in mongodb.module



tungscit’s picture

new605 bytes
FAILED: [[SimpleTest]]: [MySQL] 11 pass(es), 6 fail(s), and 0 exception(s).
[ View ]

Here is the patch

tungscit’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, connect_option_removed-1866622-0.patch, failed testing.

tungscit’s picture

Version:7.x-1.0-rc2» 7.x-1.x-dev
fgm’s picture

This would need some rationale: the module needs to support not only recent versions but, to a certain extent, older ones.

Will this soon-to-be-deprecated option cause an error if used on a recent server, or just be ignored ? And will its removal actually cause a problem on older versions ? If that's the case, the patch needs to account for both situations.

SchnWalter’s picture

Issue summary:View changes
Status:Needs work» Closed (cannot reproduce)

The "connect" option is passed to the MongoClient constructor. And I don't see it as being deprecated.

Please provide more info if you consider this to be the case and I missed something in the docs.