The preload attribute of the audio tag takes three values but jPlayer only allow you to set two of them, "auto" and "metadata". This patch adds the third option, "none".

More info at: https://developer.mozilla.org/en-US/docs/HTML/Element/audio

We are using jPlayer for our new podcast, http://drupalsnack.se/, and noticed that some browsers downloaded the whole or part of the audio file even when we had set Autoplay to No and Preload media to "No".

After applying this patch and Preload media to "No", that with this patch translates to "none", we seem to have solved the problem.

Credit for finding this problem as well as the solution goes to kristofferwiklund.

CommentFileSizeAuthor
jplayer_preload.patch558 bytesfrjo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kristofferwiklund’s picture

kristofferwiklund CreditAttribution: kristofferwiklund commented
Status: Needs review » Reviewed & tested by the community

Confirmed and fixed at a second site.

danielphenry’s picture

danielphenry CreditAttribution: danielphenry commented
Priority: Normal » Major

Excellent. Just tested this on my own site and the patch does the job perfectly.

Please submit it is a very, very much needed patch. and it's super simple. This module was almost unusable wihtout it. Especially if you know your clients often have a slow connection.

PQ’s picture

PQ CreditAttribution: PQ commented
Issue summary: View changes

This fix sorted out a bunch of issues on the site I'm working on now... Would be great to see it committed.

dieuwe’s picture

dieuwe
Location Auckland, NZ
CreditAttribution: dieuwe commented

Bump.

markie’s picture

markie CreditAttribution: markie commented
Status: Reviewed & tested by the community » Fixed

Pushed to dev branch.

  • eba283a committed on 7.x-2.x 
    git commit -m 'Issue #1865530 by frjo: Allow setting preload to none in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.