Would be lovely if I could enable/disable metatag defaults with a code push and a feature revert.

<?php
 
// Exported Metatag config instance: user.
 
$config['user'] = array(
   
'instance' => 'user',
   
'disabled' => TRUE,
   
'config' => array(
     
'title' => array(
...
?>
Files: 
CommentFileSizeAuthor
#7 metatag-n1864306-7.patch645 bytesDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]
#2 1864306-metatag-features-disable-2.patch549 byteshefox
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Comments

pbz1912’s picture

Title:Support for disabled/enabled states in features» Unable to disable default settings using features
Category:feature» bug
Issue tags:+D7 stable release blocker

I consider this a bug. It breaks the usefulness of being able to put this into features.

I want to disable the global:frontpage in code and keep it that way.
However if it is changed on the site it is impossible to revert the feature to disable that setting.

This is also a problem with an enterprise workflow where we are trying to deploy changes to the live site with code and to version control our settings. There is no way to push that change with code.

hefox’s picture

Issue summary:View changes
Status:Active» Needs review
StatusFileSize
new549 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Doesn't sound like a bug to me -- it doesn't break the feature support, just makes it less useful. People can integrate with features however they want =). Views d6 also had a similar issue.

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed. Thanks. (and properly attributed this time too)

chriz001’s picture

Im having a few problems with this change. Whenever i visit the module page i get this error:

Notice: Undefined property: stdClass::$disabled in metatag_features_export_render() (line 39 of .../metatag/metatag.features.inc).

In my exported module disabled is set to NULL. Ive tried re-exporting and enabling/disabling the module but it didn't help

chriz001’s picture

Status:Fixed» Needs review
DamienMcKenna’s picture

StatusFileSize
new645 bytes
PASSED: [[SimpleTest]]: [MySQL] 73 pass(es).
[ View ]

Gah.

chriz001’s picture

cool! Thats fixed the error for me :)

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed, thanks for reporting the bug.

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.