Missing docblocks from these three functions.

function user_is_anonymous() {
  // Menu administrators can see items for anonymous when administering.
  return !$GLOBALS['user']->uid || !empty($GLOBALS['menu_admin']);
}

function user_is_logged_in() {
  return (bool) $GLOBALS['user']->uid;
}

function user_register_access() {
  return user_is_anonymous() && (config('user.settings')->get('register') != USER_REGISTER_ADMINISTRATORS_ONLY);
}
CommentFileSizeAuthor
#14 user-module-docblocks-1864216-14.patch1.17 KBmarvin_b8
#8 user-module-docblocks-1864216.8.interdiff.txt1000 byteslarowlan
#8 user-module-docblocks-1864216.8.patch1.13 KBlarowlan
#1 user-module-docblocks-1864216.1.patch1.13 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new user-module-docblocks-1864216.1.patch1.13 KB

straight forward

Status: Needs review » Needs work

The last submitted patch, user-module-docblocks-1864216.1.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review

#1: user-module-docblocks-1864216.1.patch queued for re-testing.

tim-e’s picture

tim-e commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This patch does not follow our docs standards.
http://drupal.org/node/1354#functions

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » jhodgdon

hi @jhodgdon, I can't see what I've missed, unless it needs to be Determines instead of Determine.
Please advise?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned

Correct. all the verb tenses are wrong.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review
StatusFileSize
new user-module-docblocks-1864216.8.patch1.13 KB
new user-module-docblocks-1864216.8.interdiff.txt1000 bytes

Thanks @jhodgdon, fixed in attached.

Status: Needs review » Needs work

The last submitted patch, user-module-docblocks-1864216.8.patch, failed testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Reviewed & tested by the community

Thanks! That looks fine. The test failure is obviously unrelated (and it's one that is already reported as a critical bug, the "deadlock" error on merge queries). I'll hit retest just in case.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#8: user-module-docblocks-1864216.8.patch queued for re-testing.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

Looks like we should backport this to 7.x, which is also missing the docs on at least some of the same functions.

marvin_b8’s picture

marvin_b8 commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new user-module-docblocks-1864216-14.patch1.17 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

straight forward backport

David_Rothstein’s picture

David_Rothstein commented

#14: user-module-docblocks-1864216-14.patch queued for re-testing.

David_Rothstein’s picture

David_Rothstein commented

(pardon the noise - just checking something with the testbot)

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/77c08ef

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.