Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Missing docblocks from these three functions.
function user_is_anonymous() {
// Menu administrators can see items for anonymous when administering.
return !$GLOBALS['user']->uid || !empty($GLOBALS['menu_admin']);
}
function user_is_logged_in() {
return (bool) $GLOBALS['user']->uid;
}
function user_register_access() {
return user_is_anonymous() && (config('user.settings')->get('register') != USER_REGISTER_ADMINISTRATORS_ONLY);
}
Comment | File | Size | Author |
---|---|---|---|
#14 | user-module-docblocks-1864216-14.patch | 1.17 KB | marvin_B8 |
#8 | user-module-docblocks-1864216.8.interdiff.txt | 1000 bytes | larowlan |
#8 | user-module-docblocks-1864216.8.patch | 1.13 KB | larowlan |
#1 | user-module-docblocks-1864216.1.patch | 1.13 KB | larowlan |
Comments
Comment #1
larowlanstraight forward
Comment #3
larowlan#1: user-module-docblocks-1864216.1.patch queued for re-testing.
Comment #4
tim-e CreditAttribution: tim-e commentedLooks good to me.
Comment #5
jhodgdonThis patch does not follow our docs standards.
http://drupal.org/node/1354#functions
Comment #6
larowlanhi @jhodgdon, I can't see what I've missed, unless it needs to be Determines instead of Determine.
Please advise?
Comment #7
jhodgdonCorrect. all the verb tenses are wrong.
Comment #8
larowlanThanks @jhodgdon, fixed in attached.
Comment #10
jhodgdonThanks! That looks fine. The test failure is obviously unrelated (and it's one that is already reported as a critical bug, the "deadlock" error on merge queries). I'll hit retest just in case.
Comment #11
jhodgdon#8: user-module-docblocks-1864216.8.patch queued for re-testing.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #13
jhodgdonLooks like we should backport this to 7.x, which is also missing the docs on at least some of the same functions.
Comment #14
marvin_B8 CreditAttribution: marvin_B8 commentedComment #15
larowlanstraight forward backport
Comment #16
David_Rothstein CreditAttribution: David_Rothstein commented#14: user-module-docblocks-1864216-14.patch queued for re-testing.
Comment #17
David_Rothstein CreditAttribution: David_Rothstein commented(pardon the noise - just checking something with the testbot)
Comment #18
David_Rothstein CreditAttribution: David_Rothstein commentedCommitted to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/77c08ef