Some old code in Statistics module is calling node_load() and user_load() when it doesn't need to do so. I came across this because of an apparent bug in Workbench Moderation: #1780182: Revision tab shown in node form, if node/x/track is clicked

I'll post a patch shortly.

CommentFileSizeAuthor
#7 stats-node-user-load-removal-1863260-7.patch921 bytesnohup
#1 stats-node-user-load-removal--no-whitespace-fix-1863260-1.patch2.21 KBstevector
#1 stats-node-user-load-removal-1863260-1.patch7.89 KBstevector
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Status: Active » Needs review
FileSize
stats-node-user-load-removal-1863260-1.patch7.89 KB
stats-node-user-load-removal--no-whitespace-fix-1863260-1.patch2.21 KB

I'm posting two patches. The real patch is mostly whitespace fixes. The patch without the whitespace fix makes the change easier to see.

Status: Needs review » Needs work

The last submitted patch, stats-node-user-load-removal-1863260-1.patch, failed testing.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented
Status: Needs work » Needs review

Hmm, failing tests is one thing, but they shouldn't fail different tests.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented

#1: stats-node-user-load-removal-1863260-1.patch queued for re-testing.

stevector’s picture

stevector
he/him
CreditAttribution: stevector commented

#1: stats-node-user-load-removal--no-whitespace-fix-1863260-1.patch queued for re-testing.

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Version: 8.x-dev » 7.x-dev
Status: Needs review » Needs work

Neither of these routes exist in 8.x anymore. Moving to 7.x

iamEAP’s picture

iamEAP CreditAttribution: iamEAP commented
Issue summary: View changes

Fixing link to other d.o issue

nohup’s picture

nohup CreditAttribution: nohup commented
Issue summary: View changes
FileSize
stats-node-user-load-removal-1863260-7.patch921 bytes

With the 'me' alias module enabled user/me/track/navigation results in a "page not found". The 'me' modules replaces the user id in the URL with the string 'me'. The statistics module uses user_load(arg(1)) to load the user from the argument which fails because the user id in the URL was replaced with 'me'. The following patch users menu_get_object to load the user.

nohup’s picture

nohup CreditAttribution: nohup commented
Status: Needs work » Needs review

updating status