Move ConfigStorageController::getQuery() to EntityStorageControllerInterface

reviewing this.

I dont totally get it all yet, but the issue summary makes more sense and the patch looks good afaik.

Reviewed this. (well discussed it in irc some more and tried to understand it.)

ConfigStorageController still has a getQuery method, but its on EntityStorageControllerBase instead of having its own implementation.
EntityStorageControllerInterface says that things need to implement getQuery
ConfigStorageControllerInterface extends EntityStorageControllerInterface
so, the getQuery for config things, is using the generic getQuery defined on EntityStorageControllerBase
and it gets its special config stuff because
EntityStorageControllerInterface already required getQueryServicename()
ConfigStorageController implements getQueryServicename() { return 'entity.query.config'; }
and other things that extend EntityStorageControllerInterface have their own getQueryServicename, like
DatabaseStorageController implements getQueryServiceName() { return 'entity.query.sql'; }

-----------
Since BlockFormController already has a storage controller, might as well use it. It was changed in the patch to use getQuery() instead of a Query\QueryFactory.
MenuForm also.

So,
I tried to look to see if there were any other places like CommentAdminOverview..
Not sure if this was the best way, but did

$ ag "__construct\(" core/* | grep QueryFactory

And then opened each class.
Ones that do not have a storage controller already, are not worth injecting one, so left them just using the QueryFactory directly. (like FilterFormatFormControllerBase)

But did find two that already had a storage controller, so might as well use getQuery with that, and then we dont need the QueryFactory (it wasn't being used for anything else besides getting the query).
OpmlFeedAdd
DateFormatFormBase

There didn't seem to be any phpunit tests to update.

Running
./vendor/bin/phpunit --strict
before and after the changes yeilded the same results:
OK (4578 tests, 8197 assertions)

The most important point: The implementation should really not bypass the QueryFactory, as this is the place which controls the logic.
On top of it the getQuery method on the storage controller is just a shortcut in case you already have the storage controller available. Based on that I reverted the change in the menu controller,
as it did not needed the menu storage controller before

Nice clean up let's fix this.

¡Ay, caramba!

Committed and pushed to 8.x. Thanks!