Updated: Comment #N

Problem/Motivation

Some contexts do not accommodate disruptions in their workflow, such as creating core entities, Webforms, etc. To allow people to make payments in these contexts, a payment reference form element was developed that handled the entire payment workflow in a separate window/tab. However, for sites that only offer payment methods that process payments inline (e.g. do not redirect the user off-site) this is overkill and not user friendly.

Proposed resolution

  • Let payment method plugins specify if they interrupt the regular workflow when they execute a payment.
  • Use inline entity forms to display payment forms, or leverage #2182263: Attach field form elements to payment forms, if the selected payment method does not disrupt the workflow. Use the existing new-window-approach if it does.

Remaining tasks

...

User interface changes

Minor with backwards compatibility.

API changes

None.

Original report

The payment reference widget uses a separate ab/window for processing payments, which should be a more user friendly workflow if payment methods can be used within a context's workflow.

To do: add a a new form element (which in version 2 should replace the existing one) that can be used anywhere and only opens a new window if a user wants to pay using a payment method that is off-site.

See #1860954: Better support for inline/non-off-site payment methods.

CommentFileSizeAuthor
#77 payment_1860956_77.patch205.57 KBxano
#77 interdiff.txt1.53 KBxano
#75 payment_1860956_75.patch205.56 KBxano
#72 payment_1860956_72.patch205.49 KBxano
#70 payment_1860956_70.patch205.56 KBxano
#68 payment_1860956_68.patch205.38 KBxano
#68 interdiff.txt622 bytesxano
#66 payment_1860956_66.patch205.28 KBxano
#61 payment_1860956_61.patch200.54 KBxano
#60 payment_1860956_60.patch186.34 KBxano
#56 payment_1860956_56.patch186.37 KBxano
#54 payment_1860956_54.patch184.76 KBxano
#52 payment_1860956_52.patch164.26 KBxano
#50 payment_1860956_50.patch172.7 KBxano
#48 payment_1860956_48.patch141.57 KBxano
#44 payment_1860956_44.patch128.88 KBxano
#42 payment_1860956_42.patch128.07 KBxano
#40 payment_1860956_40.patch82.78 KBxano
#38 payment_1860956_38.patch80.65 KBxano
#37 payment_1860956_37.patch32.6 KBxano
#34 payment_1860956_34.patch38.66 KBxano
#32 payment_1860956_32.patch45.82 KBxano
#28 payment_1860956_28.patch45.82 KBxano
#27 payment_1860956_27.patch47.31 KBxano
#26 payment_1860956_26.patch41.26 KBxano
#24 payment_1860956_24.patch38.06 KBxano
#18 payment_1860956_17.patch38.71 KBxano
#15 payment_1860956_15.patch39.75 KBxano
#13 payment_1860956_13.patch38.94 KBxano
#10 payment_1860956_10.patch39.96 KBxano
#9 payment_1860956_9.patch53.37 KBxano
#8 payment_1860956_8.patch5.17 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Version: 7.x-1.x-dev » 8.x-2.x-dev
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Depends on #2105793: Port Payment Reference Field.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

This may also depend on the D8 version of Inline Entity Form.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

#2006248: Add an EmbeddableFormInterface so that FormInterface can delegate to multiple objects might remove the need for Inline Entity Form.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Issue summary: View changes
Status: Active » Postponed
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Title: Support inline payment methods in the reference widget » Support inline payment methods in payment method selectors
Issue summary: View changes

Marked #1860954: Better support for inline/non-off-site payment methods as a duplicate of this issue.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Postponed » Active

We can actually do this already. Look at EntityFormController as an example. It just called the procedural field_attach_*() functions and contains some extra logic that we should be able to duplicate.

//Edit: take a look at what #2095195: Remove deprecated field_attach_form_*() does.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_8.patch5.17 KB

Preliminary patch.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_9.patch53.37 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new payment_1860956_10.patch39.96 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 10: payment_1860956_10.patch, failed testing.

The last submitted patch, 10: payment_1860956_10.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_13.patch38.94 KB

Status: Needs review » Needs work

The last submitted patch, 13: payment_1860956_13.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_15.patch39.75 KB

Status: Needs review » Needs work

The last submitted patch, 15: payment_1860956_15.patch, failed testing.

The last submitted patch, 15: payment_1860956_15.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_17.patch38.71 KB

Status: Needs review » Needs work

The last submitted patch, 18: payment_1860956_17.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

18: payment_1860956_17.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 18: payment_1860956_17.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

18: payment_1860956_17.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 18: payment_1860956_17.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_24.patch38.06 KB

Status: Needs review » Needs work

The last submitted patch, 24: payment_1860956_24.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_26.patch41.26 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_27.patch47.31 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_28.patch45.82 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 28: payment_1860956_28.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

28: payment_1860956_28.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 28: payment_1860956_28.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_32.patch45.82 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 32: payment_1860956_32.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_34.patch38.66 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 34: payment_1860956_34.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

We may want to use a method rather than a plugin definition property to define whether or not a plugin interrupts the request. Some plugins may or may not interrupts the request based on the current context, and we don't want them to declare themselves and interruptive all the time, because plugin definitions are not dynamic.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_37.patch32.6 KB

Re-roll, but with many failures.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_38.patch80.65 KB

Status: Needs review » Needs work

The last submitted patch, 38: payment_1860956_38.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_40.patch82.78 KB

Status: Needs review » Needs work

The last submitted patch, 40: payment_1860956_40.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_42.patch128.07 KB

Status: Needs review » Needs work

The last submitted patch, 42: payment_1860956_42.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_44.patch128.88 KB

Status: Needs review » Needs work

The last submitted patch, 44: payment_1860956_44.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Related issues: +#2326377: ContentEntityBase::createDuplicate() erases the bundle value
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Related issues: +#2326273: DependencySerializationTrait serializing ContentEntityBase causes a fatal error
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_48.patch141.57 KB

AJAX works now. The workflow needs some polishing, and entity form submission does not work yet.

Status: Needs review » Needs work

The last submitted patch, 48: payment_1860956_48.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_50.patch172.7 KB

Everything works, and I added increased test coverage. What's left is to get full test coverage and to add support for fields.

Status: Needs review » Needs work

The last submitted patch, 50: payment_1860956_50.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_52.patch164.26 KB

Status: Needs review » Needs work

The last submitted patch, 52: payment_1860956_52.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_54.patch184.76 KB

Status: Needs review » Needs work

The last submitted patch, 54: payment_1860956_54.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_56.patch186.37 KB

Status: Needs review » Needs work

The last submitted patch, 56: payment_1860956_56.patch, failed testing.

Status: Needs work » Needs review

Xano queued 56: payment_1860956_56.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 56: payment_1860956_56.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_60.patch186.34 KB

Keeping up with recent changes in HEAD.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new payment_1860956_61.patch200.54 KB

Improved test coverage.

Status: Needs review » Needs work

The last submitted patch, 61: payment_1860956_61.patch, failed testing.

The last submitted patch, 61: payment_1860956_61.patch, failed testing.

Status: Needs work » Needs review

Xano queued 61: payment_1860956_61.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 61: payment_1860956_61.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_66.patch205.28 KB

Status: Needs review » Needs work

The last submitted patch, 66: payment_1860956_66.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt622 bytes
new payment_1860956_68.patch205.38 KB

Status: Needs review » Needs work

The last submitted patch, 68: payment_1860956_68.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_70.patch205.56 KB

Re-roll because of #2329401: Rename \Drupal\payment\Queue to DatabaseQueue.

Status: Needs review » Needs work

The last submitted patch, 70: payment_1860956_70.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_72.patch205.49 KB

Xano queued 72: payment_1860956_72.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 72: payment_1860956_72.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new payment_1860956_75.patch205.56 KB

Re-roll.

Status: Needs review » Needs work

The last submitted patch, 75: payment_1860956_75.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.53 KB
new payment_1860956_77.patch205.57 KB

Keeping up with recent changes in Payment.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

  • Xano committed 3bfece2 on 8.x-2.x 
    Issue #1860956 by Xano: Added Support inline payment methods in payment...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.