Split off from #1536944: Allow panes to be translated. There is code in those patches to convert the 'path' property to a field so that it can be translated with entity_translation. It made the base patch harder to review since it had not-pretty upgrade path and more complex code.

Files: 
CommentFileSizeAuthor
#4 1860486.4-fieldable_panels_pane-path-field.patch8.24 KBmrfelton
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486.4-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 1860486.3-fieldable_panels_pane-path-field.patch4.4 KBmrfelton
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486.3-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 1860486-fieldable_panels_pane-path-field.patch4.18 KBmrfelton
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Dave Reid’s picture

Status:Postponed» Active

#1536944: Allow panes to be translated has been committed, so un-postponing this.

mrfelton’s picture

Status:Active» Needs review
StatusFileSize
new4.18 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Initial patch that pulls the code out from the original patches in #1536944: Allow panes to be translated in order to handle conversion of the path property to a field, which can then be translated properly.

mrfelton’s picture

Status:Needs review» Needs work
StatusFileSize
new4.4 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486.3-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Patch updated to include (crappy) support for the title field from #1860484: Add support for Title module field. This needs work, but does the job for my current use case.

mrfelton’s picture

Status:Needs work» Needs review
StatusFileSize
new8.24 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1860486.4-fieldable_panels_pane-path-field.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Seems none of the previous patches had the update or install hooks for some reason. Patch updated.

DamienMcKenna’s picture

Assigned:Unassigned» Dave Reid
Issue summary:View changes

@Dave Reid: Given your experience with Pathauto and other path-related modules, do you think this is the correct approach?

DamienMcKenna’s picture

DamienMcKenna’s picture

Status:Needs review» Needs work
DamienMcKenna’s picture

Status:Needs work» Needs review

Testbot, do your thing.

The last submitted patch, 2: 1860486-fieldable_panels_pane-path-field.patch, failed testing.

The last submitted patch, 3: 1860486.3-fieldable_panels_pane-path-field.patch, failed testing.

dsnopek’s picture

Status:Needs review» Needs work

Looking at the patch, the hook_install() is creating the field and instance, but that only happens initially when the module is first installed. The hook_update_N() is moving the data from the column on 'fieldable_panels_panes' to the new field, but it isn't creating the field and instance!

Also, when users add a new FPP type via the UI, it doesn't appear to be creating the new instance (unless I'm missing it somewhere).

Marking as "Needs work"!

The last submitted patch, 4: 1860486.4-fieldable_panels_pane-path-field.patch, failed testing.

DamienMcKenna’s picture

Removing this from the schedule for 1.6.