Currently, the Media module uses the "Administer Files" permission from File Entity to give access to the "Media Browser settings" at admin/config/media/browser where, for instance, you can control what file extensions are permitted.

The Administer Files permission also allows access to admin/content/file which is a really nice file overview for content editors.

I think it would be great to split up the media configuration from administer file, which is what this issue is going to try and accomplish.

The patch below creates a new permission "Administer media browser" which will be used to control access to the media browser settings.

Similar issue in File Entity:
#1774292: admin/content/file shouldn't use the same permission as Media's Media Browser settings configuration?

CommentFileSizeAuthor
#5 media-add_administer_media_permission-1857218-5.patch922 bytesbneil
#3 media-add_administer_media_permission-1857218-3.patch956 bytesbneil
#1 media-add_configure_media_permission-1857218-1.patch953 bytesbneil

Comments

bneil’s picture

bneil commented
Assigned: bneil » Unassigned
Status: Active » Needs review
StatusFileSize
new media-add_configure_media_permission-1857218-1.patch953 bytes

The attached patch creates a "Configure media browser" permission that is then used to determine access to admin/config/media/browser instead of "Administer files".

ParisLiakos’s picture

ParisLiakos commented

Sure, sounds good:)
But i would prefer "administer media browser" instead of configure

bneil’s picture

bneil commented
Title: Create "Configure media browser" permission for media browser settings » Create "Administer media browser" permission for media browser settings
StatusFileSize
new media-add_administer_media_permission-1857218-3.patch956 bytes

Great, here's the updated patch.

bneil’s picture

bneil commented
Assigned: Unassigned » bneil
Status: Needs review » Needs work

Per rootatwc's request, I'm removing 'restrict access' => TRUE.

bneil’s picture

bneil commented
Status: Needs work » Needs review
StatusFileSize
new media-add_administer_media_permission-1857218-5.patch922 bytes

Here's the updated patch.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thank you

ParisLiakos’s picture

ParisLiakos commented
Status: Reviewed & tested by the community » Fixed

commited http://drupalcode.org/project/media.git/commit/fbd2569

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

zonesny’s picture

zonesny commented

Hi. I realize this request is marked as "closed," and that this patch was committed on Dec. 26, 2012. However, the change does not exist in media.module in the latest dev release i.e. 7.x-2.0-unstable7+25-dev from Feb. 9, 2013.

Can you please update me on the status? Of course, I can simply apply the patch, but I'm more concerned why it hasn't been rolled into a release.

Thanks! Fantastic module (btw).

bneil’s picture

bneil commented

zonesny: I downloaded 7.x-2.0-unstable7+25-dev from the project page and I do see the changes. It's also in HEAD http://drupalcode.org/project/media.git/blob/refs/heads/7.x-2.x:/media.m...

Perhaps you are still referencing an older version?

bneil’s picture

bneil commented
Issue summary: View changes

Updated due to permission name change.