In FeedsSource::import() there is an exception block that ends

catch (Exception $e) {
  // Do nothing.

in fact, this exception is being stored and re-thrown after we've had a chance to do some clean up (a bit like a finally block that doesn't require PHP 5.5). The comment (and any similar comments) should be corrected to reflect this.



ianthomas_uk’s picture

Status: Active » Needs review
838 bytes

Here is a patch for the two examples I was able to find.

Replaces the "Do nothing" comment with one saying "$e is stored and re-thrown once we've had a chance to log our progress"

ianthomas_uk’s picture

Any chance of getting this committed? It's just a comment change, and it would be a shame if it bitrotted or confused anyone else.

twistor’s picture

Issue summary: View changes
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.