Posted by xjm

From #1850352: config_import_invoke_owner() should check whether a module exists before invoking its hooks. module_hook() does not check module_exists(), just function_exists(), so in certain circumstances (like during test runs), something might attempt to invoke hooks for a disabled module. Should module_hook() be changed?

Files: 
CommentFileSizeAuthor
#1 module_exists-1850988-1.patch487 bytestim.plunkett
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
487 bytes
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: PHP Fatal error encountered during run_tests.sh. See review log for details.. View

I tried this while debugging that issue and it blew up.
I can't remember where though, let's find out

Status: Needs review » Needs work

The last submitted patch, module_exists-1850988-1.patch, failed testing.

mh86’s picture

Are there any plans to get this fixed in D7 as well? I couldn't find an issue for it. This bug hit with features, where components of disabled modules got imported (#1909522: Menu links of disabled feature modules are imported)

xjm’s picture

Issue summary: View changes

Removing myself from the author field so that I can unfollow the issue. --xjm

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.