Shoud instead of should.

CommentFileSizeAuthor
#8 drupal-superfluous-that-1846510-8-D7.patch702 bytesTor Arne Thune
#8 drupal-superfluous-that-1846510-8.patch720 bytesTor Arne Thune
#5 1846510-5-field-ui-spelling.patch706 byteskim.pepper
field_ui.spelling.patch724 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Title: Spelling error in inline code » Spelling error in inline comment in field_ui.admin.inc
Component: field system » documentation
nick_schuch’s picture

nick_schuch CreditAttribution: nick_schuch commented
Status: Needs review » Reviewed & tested by the community

Im seeing no issues with this change.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Doh. :)

Committed and pushed to 8.x. Thanks!

Is this in 7.x too?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Version: 8.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)
Issue tags: +Novice

Yep, in 7.x too.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper commented
Assigned: Unassigned » kim.pepper
Status: Patch (to be ported) » Needs review
FileSize
1846510-5-field-ui-spelling.patch706 bytes

backported to 7.x

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

Unless bot comes back red, which is unlikely, this is trivial and RTBC

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 7.x.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Version: 7.x-dev » 8.x-dev
Assigned: kim.pepper » Unassigned
Status: Fixed » Needs review
FileSize
drupal-superfluous-that-1846510-8.patch720 bytes
drupal-superfluous-that-1846510-8-D7.patch702 bytes

And while we're at it...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Good catch! Committed #8 to 8.x/7.x. By the way, no need for a 7.x patch... the 8.x patch applied just as well to 7.x.

Automatically closed -- issue fixed for 2 weeks with no activity.