Duplicate entries in file_display table cause PDO Exception on installation

This table belongs to file entity.
So you uninstalled file_entity and when you re enabled got this?

Why media? this table is created by this module and it is being filled up by this as well..

OK, getting this back to media then

I had the same issue : installed media and uninstalled it, then install it again => Bam! Warning!
After reading this, I have unintalled Media and File entity, then enabled them again and now I don't have anymore the warning and it seems working right...
I should precise, I did this with the 7.x-2.0-unstable7 version.

The full message text is:

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'image__teaser__file_image' for key 'PRIMARY': INSERT INTO {file_display} (name, weight, status, settings) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array ( [:db_insert_placeholder_0] => image__teaser__file_image [:db_insert_placeholder_1] => 5 [:db_insert_placeholder_2] => 1 [:db_insert_placeholder_3] => a:1:{s:11:"image_style";s:6:"medium";} ) in drupal_write_record() (line 7106 of /var/www/lib/d7_dev/core/includes/common.inc).

Steps to reproduce:

1. Enable file_entity module
2. Configure Image's bundle file display and Save. Behind the scene {file_display} table is updated:
   

   *************************** 1. row ***************************
       name: image__preview__file_image
     weight: 5
     status: 1
   settings: a:1:{s:11:"image_style";s:15:"media_thumbnail";}
   ..
   *************************** 3. row ***************************
       name: image__teaser__file_field_file_default
     weight: 0
     status: 0
   settings: N;
   *************************** 4. row ***************************
       name: image__teaser__file_field_file_rendered
     weight: 0
     status: 0
   settings: a:1:{s:14:"file_view_mode";s:7:"default";}
   *************************** 5. row ***************************
       name: image__teaser__file_field_file_table
     weight: 0
     status: 0
   settings: N;
   *************************** 6. row ***************************
       name: image__teaser__file_field_file_url_plain
     weight: 0
     status: 0
   settings: N;
   *************************** 7. row ***************************
       name: image__teaser__file_field_image
     weight: 0
     status: 0
   settings: a:2:{s:11:"image_style";s:0:"";s:10:"image_link";s:0:"";}
   *************************** 8. row ***************************
       name: image__teaser__file_image
     weight: 0
     status: 1
   settings: a:3:{s:11:"image_style";s:6:"medium";s:3:"alt";s:0:"";s:5:"title";s:0:"";}
   8 rows in set (0.00 sec)

3. Now enable Media module and get the PDOException

The problem is in media_install() function as it tries to insert default records which are already there.

function media_install() {
  ...
  $default_image_styles = array(
    'preview' => 'media_thumbnail',
    'teaser' => 'medium',
    'full' => 'large',
  );
  ...
  foreach ($default_image_styles as $view_mode => $image_style) {
    $display_name = 'image__' . $view_mode . '__file_image';
    $display = array(
      'api_version' => 1,
      'name' => $display_name,
      'status' => 1,
      'weight' => 5,
      'settings' => array('image_style' => $image_style),
      'export_type' => NULL,
    );
    file_display_save((object) $display);
  }
}

I'm tempted to think this should be fixed in file_entity's file_display_save() method, but failing that, checking if they exist first would be helpful.

This does the job. Thanks a lot!

#10: 1844768-duplicate-file-display-error-on-install.patch queued for re-testing.

Committed #10 to 7.x-2.x.

Thanks!