Undefined variable: pane_id in commerce_shipping_recalculate_services

I committed the fix to 2.x: http://drupalcode.org/project/commerce_shipping.git/commitdiff/fe9acb8

The other notice you're seeing is not located in the commerce_shipping code. It might be happening to do the first error, but if you continue to see the bug you should take the issue to the Drupal Commerce issue queue.

The illegal offset type message is a direct result of the 'fix' and is because the parameter being provided to the "commerce_checkout_pane_load()" function should not be an array. The parameter needs to be just the index string concatenation: "'customer_profile_' . $type" and not the complete form element. The amended code is below.

function commerce_shipping_recalculate_services($form, $form_state = NULL, $ignore_shipping = FALSE) {
...
         // If the current type is on the form...
         if (!empty($form['customer_profile_' . $type])) {
           // Load the checkout pane to find its checkout pane validate callback.
-          $checkout_pane = commerce_checkout_pane_load($pane_id);
+          $checkout_pane = commerce_checkout_pane_load('customer_profile_' . $type);

           // If it has a validate callback...
           if ($callback = commerce_checkout_pane_callback($checkout_pane, 'checkout_form_validate')) {

If i apply this patch my rules for calculating the shipping costs stop their work.. The error is gone but I won't get any shipping costs :(

Do you have an idea?

If I set

$checkout_pane = '';

the recalculating works fine and every error is gone.. Any Idea if this is ok?

The patch was incorrect. googletorp committed the actual fix, so just update to the latest dev and we'll get a point release out shortly.

I don't see this fix in the commerce_kickstart dev release:
http://ftp.drupal.org/files/projects/commerce_kickstart-7.x-2.x-dev-core...

Can you please review?

Thanks.

You can just update this module inside Kickstart. Without a new point release here, Kickstart wouldn't have included it yet.

It happens again with all the new Commerce, Commerce Shipping, Addressfield, Commerce Addressbook etc...

Notice: Undefined variable: pane_id в функции commerce_shipping_recalculate_services() (строка 1150 в файле ..../sites/all/modules/commerce_shipping/commerce_shipping.module).

same problem:

Notice: Undefined variable: pane_id in commerce_shipping_recalculate_services() (line 1150 of sites/all/modules/commerce_shipping/commerce_shipping.module).

using:

commerce 1.7
commerce shipping 2.0
with shipping moved under checkout panel.

Same here when moving shipping to new page.

Using Commerce Shipping Dev fixed the issue for me.

I can confirm that I still get the Notice with 7.x-2.0

When I switch to 7.x-2.x-dev the shipping option disappears entirely. I also see other error message in the log. So, I'll need to inspect those to see if there's something on my end I would need to change, although I don't see why my code should work with 2.0 and not 2.0-dev.

My client has had me change in which panes I have placed things and the message no longer appears with this placement. So, I won't be investigating the issue when switching to dev.

I am getting the same error on commerce_shipping v 7.x-2.0. Upgrading to 7.x-2.x-dev, seemed to get rid of the error. Haven't dome more than a cursory testing though.