Node deletion should clear page cache

It might also want to clear the entity cache as well. That will prevent the $node object from appearing to continue to exist in later action in the same boostrap.

Nice find. Was this already fixed in D8?

Let's see. Moved cache invalidation to submit functions.

#6: node_deletion_clear_cache-1841900-6.patch queued for re-testing.

needs a reroll

Here we go.

thanks!
just two nitpicks i could find.

1. +++ b/core/modules/node/lib/Drupal/node/Tests/NodePageCacheTest.php
   @@ -0,0 +1,90 @@
   +  function setUp() {
   ...
   +  function testNodeDelete() {
   

   need visibility

2. +++ b/core/modules/node/lib/Drupal/node/Tests/NodePageCacheTest.php
   @@ -0,0 +1,90 @@
   +    \Drupal::config('system.performance')
   

   should use $this->container like:
   $this->container->get('config.factory')->get('system.performance');

Thank you!

thanks!
lets get it in!

Nice find.

Committed f805ecf and pushed to 8.x. Thanks!

backport patch to 7.x

hi herom, thanks for rolling this!

+++ b/modules/node/node.module
@@ -1286,6 +1286,7 @@ function node_delete_multiple($nids) {
+    cache_clear_all();

this call should happen in the form submit handlers not here, because, well, if you call that function many times programmatically, that would make things significantly slower;)

so this should go in node_delete_confirm_submit() and in node_multiple_delete_confirm_submit()

new patch.

thanks looks good!

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/df93dd2