Upload progress broken for all D6 sites [#1837910]

While working on debugging #1592680: Upload progress module breaks uploads on all D7 sites we have tested many versions of 3rd party Upload Progress Nginx module and somehow we have managed to forget that its 0.9.0 version no longer supports old configuration and requires now special extra directive: upload_progress_java_output;, but only for Drupal 6.x, while all previous versions didn't require it. We have to apply a hotfix both to HEAD and stable.

Comments

Comment #1

omega8cc CreditAttribution: omega8cc commented 11 November 2012 at 21:20

Status:

Active

» Fixed

Fixed in HEAD and stable: http://drupalcode.org/project/octopus.git/commit/37be0ce

For the record, here is a full configuration for D7 and D6, when 0.9.0 version of the Nginx module is used:

###
### Upload progress support for Drupal 7.
### http://drupal.org/project/filefield_nginx_progress
### http://github.com/masterzen/nginx-upload-progress-module
###
location ~ (?<upload_form_uri>.*)/x-progress-id:(?<upload_id>\d*) {
  access_log off;
  rewrite ^ $upload_form_uri?X-Progress-ID=$upload_id;
}
location ^~ /progress {
  access_log off;
  upload_progress_json_output;
  report_uploads uploads;
}

###
### Upload progress support for Drupal 6.
### http://drupal.org/project/filefield_nginx_progress
### http://github.com/masterzen/nginx-upload-progress-module
###
location ~ (?<upload_form_uri>.*)/x-progress-id:(?<upload_id>\w*) {
  access_log off;
  rewrite ^ $upload_form_uri?X-Progress-ID=$upload_id;
}
location ^~ /progress {
  access_log off;
  upload_progress_java_output;
  report_uploads uploads;
}