Picture doesn't work with AJAX callback

Adding a script and library_alter drupal.ajax to depend on the behavior for the polyfill seems like it'd work.

woops, sorry for status change.

so yeah, would be better to have that than checking for Drupal and jQuery which doesn't guarantee anything about ajax.

um that's right. We could just put the behavior in a file and remove the events bindings from the polyfill to avoid executing that all over the place.

I could live with #6, the file will be rather small and if people don't like it, they should not use the module.

Either way works for me, I'd prefer this one to avoid having contrib take that has an example and do crazy things.

+++ b/core/modules/picture/picture.module
@@ -101,6 +101,19 @@ function picture_menu() {
+    'website' => 'http://drupal.org/node/1836860',

I don't think we usually specify this fore core libraries. If we do want something we should use some documentation page, but not this issue.

Any consensus on how to proceed here?

#1 +1, no better solution right now.

Don't need the closure though.

#18: picture.js is missing from the patch.

Just curious where this issue is at, since the last patch was in December. Has this been resolved elsewhere? Is a reroll needed?

It appears this patch still applies if somebody wants to review it.

The underlying code seems to have changed a lot. The patch's code doesn't match with the current branch cod eat all. Also, will need to check whether the bug still remains.

Considering the change in name to responsive_image -

* function picture_library_info() { doesn't exist in responsive_image.module
* hence the new js file picture.js or now responsive_image.js cannot be added in the function for inclusion either

The patch needs to be recreated. Changing status to needs work.

The most recent patch relies upon making a change to picturefill, which we won't be able to do. So how viable is this? Is there another way to tackle this?

#2260061: Responsive image module does not support sizes/picture polyfill 2.2 got committed (YAY!), hence this is now unblocked :)

1. I think #6 was a significantly better approach.
2. The problem isn't clear to me. Is the problem. That picturefill.js isn't being loaded if an AJAX request adds the first responsive image? Or is the problem that we must invoke picturefill's function every time a responsive image is added to the DOM?

So:

Or is the problem that we must invoke picturefill's function every time a responsive image is added to the DOM?

That seems like a huge flaw in the polyfill?

1. +++ b/core/modules/responsive_image/responsive_image.js
   @@ -0,0 +1,16 @@
   +    attach: function () {
   +      if (window.picturefill) {
   +        window.picturefill();
   +      }
   +    }
   

   This will actually cause it to run upon loading the page also. Which is unnecessary.

   I wonder if it'd be better to override

   Drupal.ajax.success<code> instead? Then we really only call it in case of an AJAX response.
   
   Though perhaps that's an optimization that's not worth it.
   
   If we'd know how much it costs to call <code>window.picturefill()

   when there is no work to be done, but there are actual <picture> elements on the page.

   Profiling this at http://scottjehl.github.io/picturefill/, it doesn't seem like there's any significant cost. Can you confirm that, @attiks?

2. +++ b/core/modules/responsive_image/responsive_image.libraries.yml
   @@ -0,0 +1,4 @@
   +drupal.responsive_image:
   

   Let's s/drupal.responsive_image/ajax/.

   Because, this is really only necessary for AJAX requests; the current name implies its' more generally useful, but it's definitely not.

Needs review.

you means file name should be i1836860-38-ajax.patch

#44 applies to HEAD. Removing the "Needs reroll" tag.

New patch:

• Rename as suggested in #38.
• Moved the js file to a js folder as it seems to be the standard throughout core

New patch based on #48

Renamed the behavior to responsiveImageAJAX since the standard seems to be camelCase for behaviors.

Committed 3473bd5 and pushed to 8.0.x. Thanks!