Problem/Motivation

At this moment, menu links are using an identifier based on the mlid of the menu. This is not correct, because mlid can change from site to site.

Proposed resolution

Build the identifier based on the path of the menu link, remove the use of the mlide.

Remaining tasks

After fix this, complete: #1804562: Test for MenuConfiguration handler

User interface changes

None

API changes

None

CommentFileSizeAuthor
#4 1836702.fix-menu.patch22.47 KBdagmar
#3 1836702.work-in-progress-do-not-test.patch13.39 KBdagmar

Comments

dragonwize’s picture

dragonwize commented

Users can have multiple menu items pointing to the same place, often in different menus, but I don't think we can rely on just the path.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented

Yes, I mean based on menu_name + menu_path like features module does at this moment.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
StatusFileSize
new 1836702.work-in-progress-do-not-test.patch13.39 KB

Tests are not completed yet, but basic functionality is working.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Active » Needs review
StatusFileSize
new 1836702.fix-menu.patch22.47 KB

This patch fix the implementation of Menu and Menu links and includes the tests.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Fixed

Committed & Pushed to 7.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.