Child ticket of #1775842: [meta] Convert all variables to state and/or config systems.

CommentFileSizeAuthor
#5 1830936-menu_override_parent_selector-4.patch2.47 KBvijaycs85
#1 1830936-0-menu_override_parent_selector.patch2.46 KBmtunay

Comments

mtunay’s picture

mtunay commented
Status: Active » Needs review
StatusFileSize
new 1830936-0-menu_override_parent_selector.patch2.46 KB

First patch..

aspilicious’s picture

aspilicious commented

#1: 1830936-0-menu_override_parent_selector.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1830936-0-menu_override_parent_selector.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

Re-rolling with update_N and change in variable value.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 1830936-menu_override_parent_selector-4.patch2.47 KB

Status: Needs review » Needs work

The last submitted patch, 1830936-menu_override_parent_selector-4.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

#5: 1830936-menu_override_parent_selector-4.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1830936-menu_override_parent_selector-4.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

#5: 1830936-menu_override_parent_selector-4.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1830936-menu_override_parent_selector-4.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

#5: 1830936-menu_override_parent_selector-4.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Re-testing as it looks like testbot issue:

Detect invalid repository information Ensure the version control system is functioning properly.

Status: Needs review » Needs work

The last submitted patch, 1830936-menu_override_parent_selector-4.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

#5: 1830936-menu_override_parent_selector-4.patch queued for re-testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

oh yeah, finally I won testbot :)

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Lets retest, if it's green it's rdy to go

aspilicious’s picture

aspilicious commented

#5: 1830936-menu_override_parent_selector-4.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.