Convert theme_taxonomy_overview_terms to twig.

Comments

jenlampton’s picture

Component: Twig templates » Twig templates (front-end branch)
Status: Needs review » Needs work

no no no.

Having a template that prints a single variable is going to drive our entire front-end community nuts. We need to actually give them something in this template file to override, or at least a hint of where to go to get at what they wanted.

I'm thinking our twig template should look something like this to start:

{#
/**
 * @file
 * Default theme implementation to display a terms overview form as a sortable list of terms.
 *
 * Available variables:
 * - header: The table headers.
 * - rows: The table rows.
 * - attributes: HTML attributes to apply to the table tag.
 * - children: The rendered form element children for this page.
 * - pager: The rendered pager for the page.
 *
 * @see template_preprocess
 * @see template_preprocess_taxonomy_overview_terms
 *
 * @ingroup themeable
 */
 @todo: update this file once http://drupal.org/node/1777532 is resolved.
#}
{% include "core/themes/stark/templates/theme.inc/table.html.twig" %}
{{ children }}
{{ pager }}

Progress on this template might be blocked by #1778968: Convert theme_table to Twig

artofeclipse’s picture

Component: Twig templates (front-end branch) » Twig templates conversion (front-end branch)
StatusFileSize
new2.29 KB

the attached patch have re-write to taxonomy-overview-terms.html.twig and remove the include inside twig template.

artofeclipse’s picture

Status: Needs work » Needs review
jpamental’s picture

Status: Needs review » Needs work

I'm not entirely sure this is still valid. Some bits seem to be in the sandbox already, some don't seem present at all. Patch fails in both sections.

Setting back to 'needs work' but it may simply no longer be valid.

@artofeclipse can you comment?

artofeclipse’s picture

@jpamental the template already there, I think you can close this issue.

jpamental’s picture

@artofeclipse it's in the sandbox, but now needs to be converted/rerolled against core. I can put this on my list to do!

artofeclipse’s picture

I can help in this, I'm trying to do something to this initiative but there is some many documents to read, I just want to contribute to drupal 8 core, just guide me and I will do it.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)