Something for the todo list. Been getting this error on 7.2.x-dev

"Notice: Undefined index: name in _update_process_info_list() (line 205 of C:\sites\d7twig\modules\update\update.compare.inc)."

I traced it to the bad.info file in code_sniffer/Tests where name is intentionally omitted. This appears whenever I run admin/reports, when running admin/rmodules I get the above message followed by

"Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of C:\sites\d7twig\modules\system\system.admin.inc)."

for each module found, then

"Warning: uasort(): Array was modified by the user comparison function in system_modules() (line 800 of C:\sites\d7twig\modules\system\system.admin.inc).
Notice: Undefined index: name in _system_modules_build_row() (line 982 of C:\sites\d7twig\modules\system\system.admin.inc)."

Eliminating the error is easy by including "name" in bad.info but not sure how this would effect tests. Also why is the tests directory in code_sniffer Camelcased "Tests" when all the others are lowercase.

CommentFileSizeAuthor
#4 coder-silence_notice_from_bad_module-1828330-4.patch730 bytesarnested

Comments

douggreen’s picture

douggreen commented

I'm hoping we decide to remove these files and move to #1828864: Automated testing for coder_sniffer. Can we mark this a duplicate?

ctmattice1’s picture

ctmattice1 commented
Status: Active » Closed (duplicate)
alan d.’s picture

alan d. commented

With no patch in #1828864: Automated testing for coder_sniffer, should this remain open? This looks to me as a novice coding error with the resulting GIGO warnings seen. So not even sure why it has tests.

i.e. http://drupal.org/node/542202 These first 3 properties are clearly written as being required

arnested’s picture

arnested commented
StatusFileSize
new coder-silence_notice_from_bad_module-1828330-4.patch730 bytes

The attached patch will get around the warning be making the module hidden.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Component: Code Sniffer » Coder Review
Status: Closed (duplicate) » Reviewed & tested by the community

I think that this is quick and painless to fix and there might be followups but I don't see any reason not to apply #4 and make the bad boy to get a little more silent ;)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Category: task » bug
Priority: Normal » Major

Man, didn't see this, despite searching, and created a dupe. Let's try some other keywords to help the next person.

Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of modules/system/system.admin.inc).
Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of modules/system/system.admin.inc).
Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of modules/system/system.admin.inc).
Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of modules/system/system.admin.inc).
Notice: Undefined index: name in system_sort_modules_by_info_name() (line 949 of modules/system/system.admin.inc).
Warning: uasort() [function.uasort]: Array was modified by the user comparison function in system_modules() (line 800 of modules/system/system.admin.inc).
Notice: Undefined index: name in _system_modules_build_row() (line 982 of modules/system/system.admin.inc).

"modules page"

There we go. ;) Confirm the RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: undefined index :name » Notices on modules page after downloading Coder
Component: Coder Review » Coder Sniffer

Putting against the proper component, also re-titling to something I might've found. :)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Reviewed & tested by the community » Fixed

Committed this workaround until we have proper tests, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Media Crumb’s picture

Media Crumb commented

is there a solutoin for this? Still getting the error with a completely fresh install of D7