I wonder how this have been missing before, but ECK entity properties are not available on "Manage Fields" form (field_ui_field_overview_form)

CommentFileSizeAuthor
#30 eck_make-property-fields-configurable_1824772_30.patch1.37 KBbabruix
#21 eck_make-property-fields-configurable_1824772_21.patch2.49 KBdarren.fisher
#11 eck-add_properties_to_manage_field_forms-1824772-6.patch1.4 KBacrazyanimal
#11 eck-make_managed_property_fields_configurable-1824772-11.patch3.15 KBacrazyanimal
#6 eck-6728026-3.patch993 byteswebadpro
#5 eck-6728026-2.patch795 byteswebadpro
#1 eck_1824772-1.patch1.15 KBOnkelTem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented
Status: Active » Needs review
FileSize
eck_1824772-1.patch1.15 KB

The patch simply implements hook_field_extra_fields().

webadpro’s picture

webadpro CreditAttribution: webadpro commented

I think this should get commited.

ff1’s picture

ff1 CreditAttribution: ff1 commented
Status: Needs review » Reviewed & tested by the community

This patch works perfectly.

webadpro’s picture

webadpro CreditAttribution: webadpro commented
Status: Reviewed & tested by the community » Needs review

Patch Doesn't work properly.

webadpro’s picture

webadpro CreditAttribution: webadpro commented
FileSize
eck-6728026-2.patch795 bytes

Patch @ #1 was always replacing the last field.

Here's a fixed version.

webadpro’s picture

webadpro CreditAttribution: webadpro commented
FileSize
eck-6728026-3.patch993 bytes

Better fix.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented

@webadpro

Would you explain, what the added part exactly does?

$extra[$entity_type->name][$bundle->name]['display'][$property_name] = array(
    'label' => $property_info['label'],
    'description' => t('Entity property'),
     'weight' => 0,
);
webadpro’s picture

webadpro CreditAttribution: webadpro commented

Adds the fields in the manage display section. :)

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented

Oh yeah...
I use Display Suite which adds them automatically. That's why I never lost them :)

webadpro’s picture

webadpro CreditAttribution: webadpro commented

Actually I dont think DS adds them. Are you using your other patch?
Ref: http://drupal.org/node/1787460

acrazyanimal’s picture

acrazyanimal CreditAttribution: acrazyanimal commented
FileSize
eck-make_managed_property_fields_configurable-1824772-11.patch3.15 KB
eck-add_properties_to_manage_field_forms-1824772-6.patch1.4 KB

I have actually been meaning to add this for a while. Thanks for getting the ball rolling. The patch in #6 does not apply properly for me against 7.x-2.x-dev. I manually threw it in though and it seems to work great to me. I would mark this as RTBC and commit it, but I don't like the idea of making all properties automatically show up in the manage/display fields tabs. It is likely that you will not want to expose all of your properties all the time. I propose making them configurable per bundle which properties to expose.

I have re-rolled @OnkelTem's patch from #6 above and created an additional patch that adds the ability to configure which fields get displayed. Apply the second patch after applying the first. To configure which properties to display you must click the edit tab on the bundle admin pages.

I am prepared to commit the first and second patches once a few people have tested them out and can verify they work well.

acrazyanimal’s picture

acrazyanimal CreditAttribution: acrazyanimal commented

Note to self: re-roll patch to also give cred to @webadpro

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar commented
Status: Needs review » Reviewed & tested by the community

I have tested both patches. They are working fine.

OnkelTem’s picture

OnkelTem CreditAttribution: OnkelTem commented
Assigned: OnkelTem » Unassigned
fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tchopshop’s picture

tchopshop CreditAttribution: tchopshop commented

Somehow it's not working. I have applied the patch and the UI works... I hid the title field in my Teaser display. Then I added the Teaser to a panel and the title still shows up. I've also clicked to rewrite title (blank) and hide label inside the panel modal.

Of course I can use display:none in my CSS but I'd rather not.

tchopshop’s picture

tchopshop CreditAttribution: tchopshop commented

I should add that I'm displaying the entity via Entity Reference, so perhaps the title is getting stuck in that way?

  • Commit 91fd8e0 on 7.x-3.x authored by webadpro, committed by fmizzell: 
    Issue #1824772 by OnkelTem, webadpro: Add entity properties to Manage...

  • Commit e603466 on 8.x authored by webadpro, committed by acrazyanimal: 
    Issue #1824772 by OnkelTem, webadpro: Add entity properties to Manage...
darren.fisher’s picture

darren.fisher CreditAttribution: darren.fisher commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
eck_make-property-fields-configurable_1824772_21.patch2.49 KB

I've rerolled both patches given in #11 against eck version 7.x-2.0-rc7.

The patches in #11 failed for some reason.

Hope this helps someone.

Also re-opening issue for needs review as this would be a simple and necessary addition to eck across many use cases. It appears that this this functionality isn't part of the current release, however haven't checked the dev branch, so if this feature is in there in some form- please re-close.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Indeed indifisher. Thank you for your patch. I applied your patch #21 and it worked as expected. I searched for some days now to find this topic. It should really be a part of eck.

joelstein’s picture

joelstein CreditAttribution: joelstein commented
Version: 7.x-3.x-dev » 7.x-2.0-rc7
Status: Needs review » Reviewed & tested by the community

The patch in #21 applies cleanly and does the job. Can we get it committed?

joelstein’s picture

joelstein CreditAttribution: joelstein commented
Related issues: +#1867614: Export bundle 'config' field to features

By the way, for Features support, this patch should be committed: #1867614-3: Export bundle 'config' field to features

fmizzell’s picture

fmizzell CreditAttribution: fmizzell commented
Status: Reviewed & tested by the community » Fixed
joelstein’s picture

joelstein CreditAttribution: joelstein commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pianomansam’s picture

pianomansam CreditAttribution: pianomansam commented
Version: 7.x-2.0-rc7 » 7.x-2.x-dev

I was very confused because I have 7.x-2.0-rc7 and this issue is not resolved on it. So I'm marking this as being fixed on 7.x-2.x-dev as having it marked as rc7 is misleading.

babruix’s picture

babruix CreditAttribution: babruix commented
FileSize
eck_make-property-fields-configurable_1824772_30.patch1.37 KB

Re-rolling patch for 7.x-2.0-rc8.
As eck_entity_info_alter already in eck.module, only needed is to patch eck.bundle.inc file.