Username validation only occurs on registration form

This is a bug in the form_alter, I believe. The only form that is being validated against is the user_register form.

Attached patch fixes it for me. I did a bit of refactoring here to get the affected code in line with drupal coding standards. Note, there is another permission to bypass any validation, so be sure no roles have that permission set.

Works as expected.

Note that the user should NOT have the permission 'Override custom username validation' to have validation or custom messages.

Thanks q0rban.

Off topic:
I used /^(?!(?:admin|node|user)$)[A-Za-z0-9_\.\-]{2,}$/ to have a username that:

• does NOT allow the username 'admin', node' or 'user' as this conflicts with drupal paths if used as a first argument
• does NOT allow spaces
• allows only alphanumeric characters plus a dot, underscore or hyphen
• must be minimum 2 characters.

typo

what is the conclusion here? I just noticed that my validation requirements are still bypassed when the user edits their existing username. The requirements are there for new registrations.

I am confused by #5 above. This does not seem to be working as expected. I am using 7.x-1.1.

The patch in #2 worked fine for me.
Hey how about a commit and push dev to 1.2?

This problem can be fixed easily be editing line 224 of the custom_username_validation.module file to change the if statement as shown in the code below to include the:

user_profile_form

form.

function custom_username_validation_form_alter(&$form, &$form_state, $form_id) {
  if ($form_id == 'user_profile_form' || $form_id == 'user_register_form') {

Problem solved.

Hopefully the module author will make this change in the official code.

Attached it the simplified patch outlined above.

Thanks for that, @sprite and @firewaller! Looking back, it appears the patch in #2 is identical in function, but adds some readability improvements. Either way the maintainer chooses should be fine. :)

Hi everyone,

thanks for the patches, unfortunately, as stated in the module description, this project is not maintained any more and is seeking an new maintainer. I haven't been working with Drupal for some years.

If you're interested in taking over, please drop me a note.

- Stefan

Quick note: Today, lolandese offered his help to maintain the module, and I thankfully added him as co-maintainer.

Thanks for adding me.

James, thanks for your contribution.