hi
i am getting this error on feature setting pages "Strict warning: Only variables should be passed by reference in features_override_module_component_overrides() (line 145 of C:\wamp\www\matakastage\sites\all\modules\features_override\features_override.export.inc)."
i am using wamp 2.2 with php 5.4.3 mysql 5.5.24 and apache 2.4.2 with drupal 7.16
feature override error

CommentFileSizeAuthor
#5 features_override-pass-variable-by-reference-1823388-5.patch701 byteslogaritmisk
#4 features_override-pass-variable-by-reference-1823388-4.patch1.04 KBlogaritmisk
#1 features_override-pass-variable-by-reference-1823388-1.txt1.04 KBkasperg
#2 features_override-pass-variable-by-reference-1823388-2.patch1.04 KBkasperg
features_override_error.jpg40.08 KBasif_khan

Comments

kasperg’s picture

kasperg commented
StatusFileSize
new features_override-pass-variable-by-reference-1823388-1.txt1.04 KB

Here is a quick patch to fix this issue for 2.x-dev. It should apply to 2.0-beta1 too.

kasperg’s picture

kasperg commented
Version: 7.x-2.0-beta1 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new features_override-pass-variable-by-reference-1823388-2.patch1.04 KB

And now as a proper patch.

mpotter’s picture

mpotter commented
Status: Needs review » Reviewed & tested by the community
logaritmisk’s picture

logaritmisk commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new features_override-pass-variable-by-reference-1823388-4.patch1.04 KB

Missing ; on line 150.

logaritmisk’s picture

logaritmisk commented
StatusFileSize
new features_override-pass-variable-by-reference-1823388-5.patch701 bytes

My prev. patch faild to apply with drush make, so I created a new patch.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Needs review » Reviewed & tested by the community

#5 works as expected

Moinax’s picture

Moinax commented

I confirm #5 works as expected, should be merged in dev and beta version.

andrew_mallis’s picture

andrew_mallis commented

#5 works as expected for us also.

mpotter’s picture

mpotter commented
Status: Reviewed & tested by the community » Fixed

Committed to f8ef5e1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.