Field should behave like taxonomy-term reference field.

CommentFileSizeAuthor
#8 1821060_8.patch3.71 KBamitaibu
#7 1821060_followup.patch705 bytesamateescu
#4 1821060-er-optgroup-7.patch12.49 KBamitaibu
#3 1821060-er-term-widget-2.patch2.06 KBamitaibu
#3 optgroup.jpg6.53 KBamitaibu
#2 er-term.jpg18.83 KBamitaibu
#1 1821060-er-term-widget-1.patch1.93 KBamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Active » Needs review
FileSize
1821060-er-term-widget-1.patch1.93 KB

Extend term's getReferencableEntities()

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
er-term.jpg18.83 KB

er-term.jpg

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
optgroup.jpg6.53 KB
1821060-er-term-widget-2.patch2.06 KB

Patch supports OptGroups in case of multiple bundles.
optgroup.jpg

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Title: Widget should allow showing taxonomy terms hierarchy » Return values from getReferencableEntities() keyed bu bundle
FileSize
1821060-er-optgroup-7.patch12.49 KB
  • This will result with optgroup for all reference, unless there is only a single bundle in the result
  • Uses taxonomy_get_tree() for term reference

Adapted tests.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Title: Return values from getReferencableEntities() keyed bu bundle » Return values from getReferencableEntities() keyed by bundle
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Needs review » Fixed

Committed.
I have created a change-record -- http://drupal.org/node/1824434

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Fixed » Needs review
FileSize
1821060_followup.patch705 bytes 
+++ b/entityreference.module
@@ -762,7 +762,12 @@ function entityreference_field_widget_settings_form($field, $instance) {
+  if (count($options) == 1) {
+    $key = key($options);
+    $options = $options[$key];
+  }
+  return $options;

I think here you only want this:

return (count($options) == 1) ? reset($options) : $options;

Patch attached :)

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
1821060_8.patch3.71 KB

Patch makes sure getReferencableEntities() return the bundle's machine-name. and hook_options_list() changes that to the label.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
Status: Needs review » Fixed

Committed. Going to re-roll 8.x accordingly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.