Patch includes a new preprocess function for the install page.

CommentFileSizeAuthor
#1 theme_func_consolidation-1821006-1.patch745 bytesvlad.dancer
install-page.patch620 bytesEVIIILJ

Comments

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Active
StatusFileSize
new theme_func_consolidation-1821006-1.patch745 bytes

I have a question! Why just not replace theme_install_page by theme('maintenance_page__install_page')? Is it necessary to use one more func (theme_install_page) just to add http header and call another one?

Here patch that do this staff.

decafdennis’s picture

decafdennis commented

@#1: There is room for improvement in a lot of instances, but the goal here is to convert everything to Twig. Not sure if we want to consolidate and refactor at the same time.

jenlampton’s picture

jenlampton
she / her
commented
Component: Twig templates » Twig templates conversion (front-end branch)
Status: Active » Closed (fixed)

@naquah we are taking inventory of everything that can/should be consolidated here. I have added this function to the spreadsheet, and opened a issue against suggesting we remove this theme function entirely: #1885714: Remove theme_install_page()

@EVIIILJ patch applies cleanly but the addition of $variables['content'] duplicates the body of the page, since the content is also added by the maintenance page template & preprocess. This feels like a little bit of a hack, but changing theme_hook_original to maintenance page seems to do the trick :)

$variables['theme_hook_original'] = 'maintenance_page';

Committed and pushed to front-end, marking this issue as fixed.

Project: » Lost & found issues

This issue’s project has disappeared. Most likely, it was a sandbox project, which can be deleted by its maintainer. See the Lost & found issues project page for more details. (The missing project ID was 1750250)