The message advising that a Drupal update is available sometimes is shown 2 or 3 times:

There is a security update available for your version of Drupal. To ensure the security of your server, you should update immediately! See the available updates page for more information and to install your missing updates.

There is a security update available for your version of Drupal. To ensure the security of your server, you should update immediately! See the available updates page for more information and to install your missing updates.
CommentFileSizeAuthor
#4 double-notification-pre-patch.png31.5 KBhaydeniv
#4 single-notification-after-patch.png27.2 KBhaydeniv
#4 update_module-duplicate_notifications-1817680-4.patch1.14 KBhaydeniv
screenshot update notification issue.png19.25 KBpere orga

Comments

Anonymous’s picture

Anonymous (not verified) commented
Version: 7.15 » 8.x-dev
Issue tags: +Needs backport to D7

Moving to D8.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Active » Closed (duplicate)

Already fixed. See #1428032: Default drupal_set_message $repeat to FALSE instead of TRUE (followup)

This is the change record: http://drupal.org/node/1827234

Anonymous’s picture

Anonymous (not verified) commented
Version: 8.x-dev » 7.x-dev
Status: Closed (duplicate) » Active

So I see from #1428032-19: Default drupal_set_message $repeat to FALSE instead of TRUE (followup) that it isn't committed to D7. The admin messages need to declare the $repeat parameter as FALSE for D7.

haydeniv’s picture

haydeniv commented
Status: Active » Needs review
StatusFileSize
new update_module-duplicate_notifications-1817680-4.patch1.14 KB
new single-notification-after-patch.png27.2 KB
new double-notification-pre-patch.png31.5 KB

This has bothered me for a while now. Simple fix. Sorry don't know how to write a test for this or if it needs one.

Here are some manual steps to test:

  1. Clean install Drupal
  2. Install a module that has a security update available (I chose entity 7.x-1.0-beta11)
  3. Edit the Article content type Tags field
  4. Try to set a default value a couple times and save the settings, you should have multiple security update notices

I have uploaded a couple screenshots to demonstrate the patch.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. As for a test you would need to get the values of the message array and test that there was only one entry for the notification. I don't think it is worth a test at this point, but if there is it would need to be a new issue for D8.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/2b86b82

Yeah, I agree, it's probably not worth the effort to write a test for this one.

Automatically closed -- issue fixed for 2 weeks with no activity.