Dynamically switch visibility setting

Why is there a need to change it dynamically? Paths can be configured statically.

We already have this dynamic $page_match = php_eval($setting_pages);. You can use PHP code.

http://drupal.org/node/261997 or #260367: Roles Opt-Out Sample PHP Script With Path Settings Functionality Preserved may be of interest.

The example is for roles, but can be rewritten to archive your specific needs. You may also call your function from the php code snippet to make it not messy in the textarea.

Sounds really strange what you are doing there... why are you doing this? You lose so much info... Node specific counters? Why not using events for this?

The plan was to make visibility 100% compatible with block visibility. This works great for a very long time and has the most flexibility. If core changes GA will follow core. Are you aware of such a hook feature in core blocks visibility?

Setting requested status

Why is this closed? Using php code inside text area is not recommended, for starters it won't be tracked by source control, and it can easily break the site. Plus the fact that this is just a one line change, I'm baffled why this is closed without explanation.

#9 is the answer.

Alex's later reply showed #9 is not a good reason. Also per https://www.drupal.org/node/1203886, php module was removed from D8, and block module in D8 no longer uses php module, per #9 will you follow the core to remove it from D8 version of GA? You might as well start with D7 version...

This is a D7 issue. I'm not going to remove code in D7 and current D8 code still supports php module. If you can show me just one example in core that such an alter hook exists I'm fine with adding it.

Code style is not acceptable.

Yeah, I'm not suggesting removing any code from any version, just adding a way to change visibility from code as a backup given now php module is on its way out. I'm not sure about the problem with the alter hook style, could you clarify what exactly is the issue here?

This is not core code style, has tabs. Show we first how you are able to alter block visibility with an alter hook and why the path based solution does not work, please.

So the style concern is just tab character in the patch? I think that should be easy to fix.

For alter block visibility via hook, Alex has showed it, see hook_block_list_alter, the example given there altered block visibility based on active language.

Path based solution doesn't always work, otherwise there wouldn't be the need for php module integration, right? This hook just provides an alternative to php module integration.

I do not think hook_block_list_alter was made for what you try to abuse it here... :-)

Hmmm, but the API document for hook_block_list_alter has an example of altering block visibility, I think it came from block.api.php, so this usage should be official?

I just made php module green and created a working release as a side note.

Need this feature as well since we have certain other conditions except for pages and roles that determine if the user should be tracked or not. Is it something that will be added?

Updating this issue and closing #2733291: Add alter hook to _google_analytics_visibility_pages() as duplicate.
This is a reference to a concrete case: #2731279: Add google_analytics hook to skip default GA integration for AMP pages.

Updated check in google_analytics.api.php to have an more sensible example :)

Added a test but not sure how to fix it. No google-analytics script is shown...

Tried to fix the test debugging some functions, if the debug statements are there the test passes, otherwise it fails. Looks like a caching problem... will figure it out after lunch.

Re-roll against latest development version.

With the sunset of legacy google analytics, the 8.x-2.x module is now unsupported. If this is still an issue with the 4.x version, please file a new issue in the queue.