field sql storage test failing on various MySQL engines due to indexing unbound text fields.

A bug fix and a test fix. Hopefully that's not too many kittens. :-)

I was a little confused about what this code was doing, but basically hook_schema() supports adding indexes as either array('column_name') or array('column_name', 255). Worked out a comment with chx on IRC above each section:

      // Indexes can be specified as either a column name or an array with
      // column name and length. Allow for either case.

Test changes look good. Committed and pushed to 8.x. Thanks.

Backported to D7.

i confirm patch #6 working in latest drupal core 7.35 in two sites for module advpoll

Confirming that #6 works well with MySQL and is written with good conditionals that it doesn't break anything in 7.x.

Looks like a testbot fluke.

Testbot fluke; back to RTBC.

#6 working good, waiting for next release of core, tested without problems

Committed to 7.x - thanks!

Fixed on commit:

diff --git a/modules/field/modules/field_sql_storage/field_sql_storage.module b/modules/field/modules/field_sql_storage/field_sql_storage.module
index b49e95a..842893a 100644
--- a/modules/field/modules/field_sql_storage/field_sql_storage.module
+++ b/modules/field/modules/field_sql_storage/field_sql_storage.module
@@ -223,6 +223,8 @@ function _field_sql_storage_schema($field) {
   foreach ($field['indexes'] as $index_name => $columns) {
     $real_name = _field_sql_storage_indexname($field['field_name'], $index_name);
     foreach ($columns as $column_name) {
+      // Indexes can be specified as either a column name or an array with
+      // column name and length. Allow for either case.
       if (is_array($column_name)) {
         $current['indexes'][$real_name][] = array(
           _field_sql_storage_columnname($field['field_name'], $column_name[0]),
@@ -340,6 +342,8 @@ function field_sql_storage_field_storage_update_field($field, $prior_field, $has
         $real_name = _field_sql_storage_indexname($field['field_name'], $name);
         $real_columns = array();
         foreach ($columns as $column_name) {
+          // Indexes can be specified as either a column name or an array with
+          // column name and length. Allow for either case.
           if (is_array($column_name)) {
             $real_columns[] = array(
               _field_sql_storage_columnname($field['field_name'], $column_name[0]),

(i.e., I added the same code comments to Drupal 7 that were added to Drupal 8 in #4 - these did not make it into the patch)