Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The views form labels don't follow generic core class naming and the form label is made bold where no other form label on a site is bold. I'm not sure what the reason for this is and I'd like to remove this as this would otherwise required extra theming only for views.
[css/views.css]
.views-exposed-form label {
font-weight: bold;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | views-remove-overriding-styling-exposed-form-1812028-23.patch | 267 bytes | gpollner |
| |||
| #13 | view_bold_label.png | 103.41 KB | bookmarvel |
Comments
Comment #1
dawehnerJust update the issue for easier finding. (if you look at the tpl) you will know the difference.
Comment #2
hass CreditAttribution: hass commentedviews-exposed-form.tpl.php:-(. But I see no comment why the label need to be bold.Comment #3
hass CreditAttribution: hass commentedAside the form is missing the
element-visibleand other classes that we have for blind people.Comment #4
dawehnerWell this allows actual theming, that's my oppinion, but probably back in the days you also needed a certain look and field.
Another reason is the special handling of checkboxes, see template_preprocess_views_exposed_form
But sure, cleaner code would be better, so feel free to work on this issue.
Comment #5
xjmComment #6
xjm#1812048: Build the exposed form using form API functions would probably help with some of what @dawehner describes in #4.
Comment #7
dead_armI believe that the views exposed form label styling was removed when the views.css sheet was refactored into views.base.css. Exposed form labels now use the enabled theme's label styling.
Comment #8
hass CreditAttribution: hass commentedThis sounds good. Than we just need zo backport to D7.
Comment #9
dawehnerThere is no reason to backport that, as this changes the visual output.
Comment #10
hass CreditAttribution: hass commentedWhat is the problem with fixing visual inconsistency bugs?
Comment #11
dawehnerNoone will do it?
Comment #12
hass CreditAttribution: hass commentedNot sure about your comment. Should I roll a patch?
Comment #13
bookmarvel CreditAttribution: bookmarvel commentedComment #14
manningpete CreditAttribution: manningpete commentedAdding to bookmarvel's screenshot in comment #13, we created a view in d7 and exposed the filter to test its boldness. Then we created a view in d8 to verify it was no longer bold, but it was in fact still bold. We looked for the .views-exposed-form and found that it is no longer adding any extraneous bolding. The bold comes from the line 38 in drupal.base.css, which adds bold to the .label class.
It seems that the default behavior for labels is now bold, but views css is no longer affecting that, so unless we misunderstand, we think this ticket can be closed (won't fix) because the original issue (that views was adding a class override) is no longer valid.
Also, dawehner and I discussed backporting on IRC and both leaned against it, in that it would change styling in already-live sites with no clear benefit.
Comment #15
hass CreditAttribution: hass commentedWhat is drupal.base.css? That's your theme. The views style is not consistent with d7 core as I know.
Comment #16
dawehner@Hass
Do you have an oppinion about that? This is basically the same problem as we had with the string freeze, but I consider it as worse.
Comment #17
hass CreditAttribution: hass commentedI think we should make it consistent and fix this bug. We are only removing a bold style here. So if someone has overridden the style in the theme they will not see any difference at all. Others will experience a consistent style within all forms and may be happy. It cannot really break anything, but I leave this up to you now. Just reopened it as #13 and #14 is just wrong.
I've overridden it in my distributions and would be happy to get rid of the overriding, but will not fight for it as it has been fixed in D8.
Comment #18
manningpete CreditAttribution: manningpete commentedI'm really sorry I seemed to have made some mistake here, but I honestly do not know what it is. Can you please explain what I wrote in #14 that is "just wrong"? I have been using Drupal for many years but am very new to "contributing" and am trying to do things the right way. I was at a contrib meetup when I posted that, working with another developer, and asked my mentor (YesCT) whether it was appropriate to close it. Is that what was "just wrong"? It would be helpful if you could explain what I did wrong so I don't do it again.
You asked what is drupal.base.css, and I'm not sure if that was rhetorical, but I believe that's the default theme in Drupal 8 that comes with core. Without making any changes to core or any themes, those labels (all labels) are bold.
Comment #19
hass CreditAttribution: hass commentedThis is a D7 or D6 issue, not D8. There is no drupal.base.css in D7 and the issue is already fixed in D8. See #1812048: Build the exposed form using form API functions
Comment #20
manningpete CreditAttribution: manningpete commentedMy confusion comes from the fact that this was marked as a D8 issue until it was changed to D7 yesterday, after I made my "just wrong" comment. Sorry I misunderstood the issue.
Comment #21
MustangGB CreditAttribution: MustangGB commentedLooks like dawehner's prediction in #11 was correct.
Comment #22
DamienMcKennaBut it does mean we have a novice D7 issue, and I happen to have need of one..
Comment #23
gpollnerComment #24
gpollner