term name is not used as page title when a menu item links to it [#1811426]

If you create a menu link to a term, where the term name is not equal to the menu name, the menu name is displayed on the page instead of the term name.

In the default implementation of the function taxonomy_term_page($term), the term name will be set by using the following code:

  // Assign the term name as the page title.
  drupal_set_title($term->name);

So, when i enable taxonomy_display, the page title is not the terms name, because this line is missing in taxonomy_display_taxonomy_term_page().

Comment	File	Size	Author
#1	taxonomy_display-term-name-not-used-for-title-1811426-1.patch	669 bytes	codycraven

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

codycraven CreditAttribution: codycraven commented 15 October 2012 at 18:45

Status:

Active

» Fixed

File	Size
taxonomy_display-term-name-not-used-for-title-1811426-1.patch	669 bytes

Interesting... I apparently didn't notice that about taxonomy_term_page().

In taxonomy_display_menu_alter() the title callback is set to: taxonomy_display_taxonomy_term_title which does:

function taxonomy_display_taxonomy_term_title($term) {
  return function_exists('i18n_taxonomy_term_name') ?
      i18n_taxonomy_term_name($term) : taxonomy_term_title($term);
}

Which I thought would be sufficient... I'm a little bit torn about this, but I guess what taxonomy_term_page() is doing is the expected functionality.

Commit to follow.