Add missing type hinting to Dblog module docblocks

Hi I am in high school and very new to drupal. I have attempted a patch and have attached it :)

Thanks for the patch and welcome to Drupal!

This looks pretty good. I'm not sure if it fixes all the problems in dblog, but someone else can check it.

One problem: In text, "id" is a Freudian term (ego, superego, id), so it shouldn't be used in documentation. "ID" is what you want to use in Drupal docs (means "identifier" or "identification").

+   * @param int $id
+   *   The id of the watchdog log entry.
+   *

So even though the parameter name is $id (which is right), the text should say "The ID of the ...".

Actually it *does* get all the type hinting errors, according to phpcs. :-)

So all it needs is the change from #4, and it's RTBC.

Hi all, thanks for the help and advice. I think I've managed to fix that last bit :)

Hi all, thanks for the help and advice. I think I've managed to fix that last bit :)

Oh I spoke too soon... There's this, in DbLogController:

  /**
   * Formats a database log message.
   *
   * @param stdClass $row
   *   The record from the watchdog table. The object properties are: wid, uid,
   *   severity, type, timestamp, message, variables, link, name.
   *
   * @return string|false
   *   The formatted log message or FALSE if the message or variables properties
   *   are not set.
   */
  public function formatMessage($row) {

Should be object instead of stdclass, but really should be whatever interface of object is actually expected.

I think just substituting object will be good, because it documents the behavior of the method, but if you find some documentation for a more specific type by all means add that.

Thanks.

Hi, I changed that last part to object as you suggested :)

That catches the last one. Thanks for sticking with it!

The patch has unrelated stuff in it.

Hi, sorry what was the unrelated part of the patch?

Click on the file link above. https://www.drupal.org/files/issues/1811242-9-stdclass-object-corrected....

It has a bunch of stuff that is completely unrelated to adding DBLog module doc blocks in it. Looks like maybe it is the patch for a different issue?

Here's a roll of the fix from #9 without the unrelated stuff in it.

The latest patch looks fine. I haven't checked to see if it contains all needed param/return fixes in dblog.module, but it is certainly fine to commit as it is. Thanks!

Committed 1abfba4 and pushed to 8.0.x. Thanks!