Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This is a sub-issue of #1800046: [META] Add missing type hinting to core docblocks, fix Drupal.Commenting.FunctionComment.Missing* focused on correctly adding @param and @return type hinting to the Language module.
Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (20-25 as a guess).
How To Review This Issue
- Attempt to apply the patch to see if it needs a reroll.
- Use the phpcs one-liner to evaluate whether all the relevant standards errors have been resolved: https://gist.github.com/paul-m/227822ac7723b0e90647
- Look at each change and determine whether the type hint is correct.
Related sprint issues:
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 1811214-9.patch | 6.2 KB | naveenvalecha |
| #7 | 1811214-language-blockdocs-7.patch | 10.76 KB | tisteegz |
| #3 | 1811214_3.patch | 10.79 KB | mile23 |
Comments
Comment #1
lars toomre commentedCorrecting the title...
Comment #2
mile23Comment #3
mile23Something to chew on.
Comment #4
mile23Comment #5
mile23Comment #6
mile23Comment #7
tisteegz commentedRe-rolled patch.
Comment #8
mile23Bumping to 8.1.x. Patch no longer applies.
Comment #9
naveenvalechaComment #10
madhavvyas commentedCode looks good to me.
Comment #11
mile23Cool, thanks.
Patch applies, phpcs says no problems.
Comment #12
jhodgdon+1 on RTBC. Moving back to 8.0.x though as there is no reason this cannot be committed there too.
Comment #13
catchCommitted/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!