Closed (fixed)
Project:
Webform
Version:
7.x-4.0-alpha6
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2012 at 13:19 UTC
Updated:
29 Jun 2013 at 22:40 UTC
First off, thanks for #680386: Views integration for the webform_submitted_data table, whohoo! That's just awesome!
Secondly, the relationship handler defined is a bit difficult to alter as it completely overwrites the $this->definition['extra'] array rather than just adding new elements to it.
This means for my custom relationship handler, which extends webform_handler_relationship_submission_data, I can't add anything to that array - which I want to do so I can filter multi-value fields by the delta / data entered.
The attached patch fixes this so it plays likely with other relationship handlers which extend this one.
| Comment | File | Size | Author |
|---|---|---|---|
| webform_dont_trash_existing_extra_array_values.patch | 1.16 KB | stella |
Comments
Comment #1
quicksketchExcellent, thanks @stella! Glad to be getting some feedback on the new feature. I'll review this next time I'm going through the queue.
Comment #2
quicksketchCommitted. Thanks @stella!