pdrake reported in IRC that mongo version that comes with ubuntu 10.04 doesn't support mongodb_next_id need to put hook_requirements in to require mongo server version hight than 1.3

CommentFileSizeAuthor
#6 1808114-server_1_3-5.patch2.72 KBfgm
#5 interdiff-1808114-4-5.diff.txt3.55 KBfgm
#4 1808114-server_1_3.patch2.26 KBfgm
#3 server_version-1808114-3.patch2.03 KBRok Žlender
#2 server_version-1808114-2.patch2.03 KBRok Žlender

Comments

Rok Žlender’s picture

Rok Žlender commented

Quick code that does what we need putting it here so I don't lose it

$connection = new Mongo('mongodb://localhost');
$db = $con->selectDB('drupal');
$return = $db->execute('db.version();');
$version = $return['retval'];
version_compare($version, '1.3');
Rok Žlender’s picture

Rok Žlender commented
Assigned: Unassigned » Rok Žlender
Status: Needs work » Needs review
StatusFileSize
new server_version-1808114-2.patch2.03 KB

I think attached patch should do the job.

Rok Žlender’s picture

Rok Žlender commented
StatusFileSize
new server_version-1808114-3.patch2.03 KB

Patch above has some whitespace problems.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new 1808114-server_1_3.patch2.26 KB

Rerolled on today's HEAD.

Patch still works ; however, I think it would be better to rely on the standard connection handling sequence in mongodb() than roll up a new specific sequence as done here. It would be shorter and more reliably updated.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-1808114-4-5.diff.txt3.55 KB

How about this one ?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 1808114-server_1_3-5.patch2.72 KB

Missing patch itself

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • fgm committed 0dbad7b on 7.x-1.x 
    Issue #1808114 by fgm, Rok Žlender: Require mongo server version higher...
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x. Thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.