Following error pops up from privatemsg tests:

Strict warning: call_user_func() expects parameter 1 to be a valid callback, non-static method PrivatemsgFilterWidgetTestCase::getInfo() should not be called statically in simpletest_test_get_all() (line 327 of /var/www/spr/modules/simpletest/simpletest.module).

CommentFileSizeAuthor
#8 getinfo_warning_2.x-1807410-8.patch1.44 KBmikran
#1 getinfo_warning-1807410-2.patch1.44 KBmikran

Comments

mikran’s picture

mikran commented
Status: Active » Needs review
StatusFileSize
new getinfo_warning-1807410-2.patch1.44 KB

Attached patch also adds public keyword to few other implementatiots of getInfo().

Status: Needs review » Needs work

The last submitted patch, getinfo_warning-1807410-2.patch, failed testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Project: Message » Privatemsg

Wrong project...

mikran’s picture

mikran commented
Status: Needs work » Needs review

too many tabs open it seems :)

mikran’s picture

mikran commented

#1: getinfo_warning-1807410-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, getinfo_warning-1807410-2.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

You can ignore those test fails.

mikran’s picture

mikran commented
StatusFileSize
new getinfo_warning_2.x-1807410-8.patch1.44 KB

rerolled patch for 2.x branch as well

mikran’s picture

mikran commented
Status: Needs work » Needs review

and changing status for manual review then

Status: Needs review » Needs work

The last submitted patch, getinfo_warning_2.x-1807410-8.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Thanks, commited to both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.