I am using Filtered HTML as my default input format, and I've enabled all four Typogrify refinements.

I also added to the allowed tags.

None of the refinements are appearing.

Is there something else I need to do?

Comments

jiangxijay’s picture

jiangxijay commented

Follow-up. The only refinements that aren't appearing are those generated by SmartyPants; the others (in tags) are fine.

Are there known conflicts with themes or other modules?

jiangxijay’s picture

jiangxijay commented

SmartyPants/Typogrify convert quotes into curly quotes, but not " into curly quotes.

Can that be changed:? In other words, can SmartyPants (php-typogrify.php or smartypnts.php) be trained to look for the entity?

jiangxijay’s picture

jiangxijay commented

Clarification: " isn't being translated into curly quotes.

jiangxijay’s picture

jiangxijay commented

According to the original developer, support for converting " entities is in SmartyPants.

http://daringfireball.net/projects/smartypants/

Added a new option to automatically convert " entities into regular double-quotes before educating quotes. This is mainly for the benefit of people who write posts using Dreamweaver, which substitutes this entity for any literal quote char. The one and only way to invoke this option is to use the letter shortcuts for the smarty_pants attribute; the shortcut for this option is “w” (for Dream_w_eaver). (Suggested by Jonathon Delacour.)

Is this not implemented in Typogrify?

jiangxijay’s picture

jiangxijay commented

In smartypants.php, a configuration line needs to be edited to include the translation of " into curly quotes:

From this ...

$smartypants_attr = "1"; # Change this to configure.

... to this ...

$smartypants_attr = "qDew"; # Change this to configure.

However, php-typogrify.php appears to ignore this attribute.

BrightLoudNoise@drupal.org’s picture

BrightLoudNoise@drupal.org commented

Look for line 82 in smartypants.php, which should look like $convert_quot = 0; # should we translate " entities into normal quotes?

change it to $convert_quot = q; # should we translate " entities into normal quotes?

that took care of it for me.

BrightLoudNoise@drupal.org’s picture

BrightLoudNoise@drupal.org commented

To further clarify, you don't need to touch the $smartypants_attr = "1"; # Change this to configure. line.

jiangxijay’s picture

jiangxijay commented

Bingo. Thank you!

BrightLoudNoise@drupal.org’s picture

BrightLoudNoise@drupal.org commented
Assigned: Unassigned » BrightLoudNoise@drupal.org
Status: Active » Closed (fixed)
Tim Gambell’s picture

Tim Gambell commented
Status: Closed (fixed) » Active

I'll add some admin UI for this option. Thanks for tracking it down!

Tim Gambell’s picture

Tim Gambell commented
Assigned: BrightLoudNoise@drupal.org » Tim Gambell
mikl’s picture

mikl
Location Møn
commented
Title: Refinements not appearing » Better admin UI for SmartyPants settings.
Assigned: Tim Gambell » mikl
Category: support » feature
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

IMHO we should close this, because Drupal 5 has not been supported for years.

migmedia’s picture

migmedia commented
Status: Active » Closed (outdated)

Yes I second closing this issue.