Noticed a few localization issues scanning through the code. The only tricky part is when concatenating strings in entity label() methods. We need to pass through t() to ensure the labels are localized, but I'm pretty sure we shouldn't sanitize here since labels are considered user input and should be sanitized later.

CommentFileSizeAuthor
#1 redhen-localization-1803924-1.patch10.26 KBnedjo

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new redhen-localization-1803924-1.patch10.26 KB

Patch attached.

levelos’s picture

levelos commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit cef6821 on 7.x-1.x, tests, redhen-donation authored by nedjo, committed by levelos: 
    #1803924 by nedjo: Fixing localization issues.

  • Commit cef6821 on 7.x-1.x, tests, redhen-donation, relation-roles authored by nedjo, committed by levelos: 
    #1803924 by nedjo: Fixing localization issues.