As found out in #1760270: Comment translation broken?, there's a notice for form elements with a #type, which is a perfectly valid thing to do.

CommentFileSizeAuthor
#1 check-if-type-isset-1802452-1-set-access.patch756 bytesBerdir
#1 check-if-type-isset-1802452-1-do-not-set-access.patch753 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Active » Needs review
FileSize
check-if-type-isset-1802452-1-do-not-set-access.patch753 bytes
check-if-type-isset-1802452-1-set-access.patch756 bytes

And here's the patch.

Not sure if #access should be set in that case or not, here's a patch for both approaches.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Needs work

I'm afraid we need to recurse into typeless elements.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

We'll address this in #1798456: Hide shared form elements when the user has not the related permission.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Closed (duplicate)