This should be easy using the data returned by commerce_payment_transaction_statuses().

CommentFileSizeAuthor
#5 payment_transaction_status_options_list_callback-1797156-5.patch1.47 KBfoopang
#3 payment_transaction_status_options_list_callback-1797156-3.patch1.48 KBfoopang
#1 payment_transaction_status_options_list_callback-1797156-1.patch1.48 KBfoopang

Comments

foopang’s picture

foopang commented
Status: Active » Needs review
StatusFileSize
new payment_transaction_status_options_list_callback-1797156-1.patch1.48 KB

Hi rszrama, is it supposed to be added to the commerce_payment_order_transaction_add_form form in the admin UI? Please review my patch here. Thanks!

rszrama’s picture

rszrama commented
Status: Needs review » Active

Sorry, it's actually supposed to be an Entity API options list callback. I should've included that in the original post but wasn't thinkin. For an example, see where / how we're using the function commerce_order_status_options_list() in core right now.

foopang’s picture

foopang commented
Status: Active » Needs review
StatusFileSize
new payment_transaction_status_options_list_callback-1797156-3.patch1.48 KB

Hi rszrama, thanks for your explanation. Please review my patch again, thanks!

rszrama’s picture

rszrama commented
Status: Needs review » Needs work

For options lists, we shouldn't have any sanitization, though if you were sanitizing something like this, you'd only do the values and not the keys. You can remove the check_plain()'s or I can when I go to commit. For more info, see http://api.drupal.org/api/drupal/modules%21field%21modules%21options%21o...

foopang’s picture

foopang commented
Status: Needs work » Needs review
StatusFileSize
new payment_transaction_status_options_list_callback-1797156-5.patch1.47 KB

OK.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

I removed the remaining check_plain() around the option value and committed this. Thanks again, foopang! : )

Commit: http://drupalcode.org/project/commerce.git/commitdiff/741bca9

Automatically closed -- issue fixed for 2 weeks with no activity.