hook_field_attach_validate missing param docs

Yeah, that hook definitely needs some documentation love! It should have a function body and the parameters should definitely be explained. Thanks for the report!

Tagging

As is, this hook is pretty difficult to use. None of the array keys needed for $errors are provided to the hook, so you have to call into the field info API to retrieve them. I've only ever seen this hook implemented twice, in relation_unique and in some custom code. For both of those modules, they were able to simplify the implementation since relations are by their definition not translatable and the field name is well-defined on the relation entity. For reference:

  // First, retrieve the array keys we need for the $errors array.
  list(, , $bundle) = entity_extract_ids($entity_type, $entity);
  $instance = field_info_instance($entity_type, 'endpoints', $bundle);
  $field = field_info_field_by_id($instance['field_id']);
  $field_name = $field['field_name'];
  $langcode = LANGUAGE_NONE;

This hook probably needs attention for D8 so implementors don't need the boilerplate code. But for D7, I'm hesitant to roll a patch with the above since the field name might not be fixed and the field might be translatable.

Are you guys sure hook_field_attach_validate() still exists in D8?

Because I cannot find it anywhere in the code.

See
#1874300: Remove $entity_type argument from field.module functions that receive a single $entity
Change notice https://drupal.org/node/1882428

Maybe better #1969728: Implement Field API "field types" as TypedData Plugins

Done with

git log -Shook_field_attach_validate
git show a2c2367bf841ca994c0534811dcb1c2843ac6856

7.x only issue now.

@Noe_ a patch bingo during a D8 sprint is risky.

Fixed added patch for missing param docs

Thanks! Looks pretty good. A few minor typographical things to fix:

+ *
+ * @param $entity_type
+ *   The type of $entity; e.g. 'node' or 'user'.
+ * @param $entity
+ *   The entity with fields to validate.
+ * @param array $errors
+ *   An associative array of error keyed by field_name, language and delta.
  */

- Punctuation: e.g. must be followed by a comma. Or better yet, use "for example,", which is less liable to be confused with i.e..
- In Drupal we try to have serial commas, so in the last line, there should be a comma between "language" and "and".
- In the last line, error -> errors

@jhodgdon Thanks for review, I have updated the patch. Kept e.g with comma because we are using everywhere in documentation.

Thanks! Looks fine.

Thanks again! Committed to 7.x.

Thanks @jhodgdon

Weird. Issue status in #14 says I changed it to Fixed, but it was back to RTBC. ?!?

Yeh you committed the code but you change the status to RTBC!