There is a similar issue for D6: 1250594.

I would like to change the renderer itself for a Quick Tabs instance coming from code. There doesn't seem to be a way to alter this before quickset_renderer_factory is called in quicktabs_build_quicktabs.

CommentFileSizeAuthor
#4 interdiff-3-4.txt1.35 KBheddn
#4 quicktabs-allow_for_hook_alter-1795982-4.patch1.5 KBheddn
#3 quicktabs-allow-altering-custom-quicktabs-1795982-3.patch1.44 KBalcroito
#1 quicktabs-provide_alter-1795982-1.patch2.73 KBavr

Comments

avr’s picture

avr commented
Category: support » feature
Status: Active » Needs review
StatusFileSize
new quicktabs-provide_alter-1795982-1.patch2.73 KB

I'm not sure if this patch breaks other options - or if this is the best way to implement it.

(Also, there are a few code cleanup items with spacing/line endings).

RobKoberg’s picture

RobKoberg commented

This patch would be more useful if the $tabs where included in the alter. My use case is to remove some before displaying to certain roles.

There is a more in depth discussion in commons at: https://drupal.org/node/2003006#comment-7655635

alcroito’s picture

alcroito commented
Version: 7.x-3.4 » 7.x-3.x-dev
Priority: Normal » Major
Issue summary: View changes
StatusFileSize
new quicktabs-allow-altering-custom-quicktabs-1795982-3.patch1.44 KB

Attaching a patch that creates a similar $info object (with some differences) when a quicktab is a custom one (not ctools provided), and calls the drupal_alter hook on the object, allowing to change the custom tabs and settings of a custom quicktab.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
StatusFileSize
new quicktabs-allow_for_hook_alter-1795982-4.patch1.5 KB
new interdiff-3-4.txt1.35 KB

Here's a slightly different approach that keeps the same format inside the drupal_alter. Alternatively, we could build a separate alter hook that is specifically for custom tabs. But this approach follows the same spirit as quicktabs_build_quicktabs(), so I'm opting to use an optional value passed to the drupal_alter.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

bump

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Applying yet again on a commons sites. Can we get a review and commit here?

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Bump. This is just adding a drupal_alter into the code.

shaneonabike’s picture

shaneonabike commented

I can confirm that this patch works AND it's worth noting that without this patch when you have a custom QuickTabs setup it never calls hook_alter which is frustrating and unclear.

smustgrave’s picture

smustgrave commented
Status: Needs review » Closed (outdated)

With D7 EOL approaching in a month I'm starting to triage the D7 side of quicktabs queue.

If still an issue or needed for 4.0.x (latest branch) feel free to reopen