I'm experiencing a problem that has appeared fairly recently with this module, maybe with an upgrade to 7.14 or 7.15. When creating a snapshot, the generated SQL file contains only an incomplete table definition, making a restore from the snapshot impossible. It is not specific to one table; every table dump fails. So in the SQL file, before a table's INSERT commands, it creates the table, with it's schema. However, the SQL in the dump file I'm getting is like this:
[whitespace]ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci COMMENT='The base Access Control Lists table.'
Again, this happens for every table in the dump file. Apparently, there is some routine during table schema dump that no longer works properly...
Comments
Comment #1
nd987 CreditAttribution: nd987 commentedHas no one else experienced this issue? I'm going to mark it as critical because it makes installing new sites (or restoring snapshots) completely impossible.
Comment #2
AnybodyFor Drupal 7 the latest .dev - Version works fine for me. Just as hint if you have any problems with broken dumps.
Comment #3
MatthijsI have the same issue using the dev version on a local Drupal 7.17 installation. As said by nd987, this makes the module completely unusable.
Comment #4
Matthew Davidson CreditAttribution: Matthew Davidson commentedMatthijs: Are you sure? The fix committed on May 26 2012 appears to work, though of course snapshots made with 1.0 will still be broken.
Can the maintainers create a 1.1 release? Really shouldn't have a known broken version as the recommended release.
Comment #5
izmeez CreditAttribution: izmeez commented1+ for new release,
although https://drupal.org/node/901954 may be blocking the release.Comment #6
flaviovs CreditAttribution: flaviovs commentedFolks, regardless if this is fixed or not, of if there are other blocking issues, this problem deserves a big red-36px-font box on the module page warning people that the recommended release is completely broken and should not be used.
This is a grave issue. It's not only about the module not working properly. It's about complete loss of data (or, at least, loss of information that is very hard/time consuming to recreate, and that will allow you to get your site back).
This bug is nasty. It can ruin your site without you noticing. I don't know about you, but below is my most common use-case for this module:
Do it using the recommended 7.x release and suddenly you cannot reset to neither
snapshot 1
norsnapshot 1+dev
. In other words, you'd better to have fresh backups handy... Been there, done that.Comment #7
izmeez CreditAttribution: izmeez commented+1 for new release since the dev release is working.
My bad for suggesting in comment #5 that another issue #901954: file_directory_path() removed may be blocking the release. That issue does have a patch committed as a "stop-gap measure". And a related issue #901996: file_directory_path() removed is open for feedback on the patch.
Edited links above to show issue title and status.
Comment #8
Leeteq CreditAttribution: Leeteq commentedIt is entirely contradictional to have a completely broken "recommended" release and a (better) working -dev... , so either new release, or at least remove the recommended release with a project page warning while waiting for a proper release.
Comment #9
izmeez CreditAttribution: izmeez commentedPlease just tag a new release. There is no reason to wait.
The dev release works and the current release is just egg on the face of this useful module.
It's also the first module I would reach for when testing drupal 8, but it's not on everyone's priority list.
Comment #10
izmeez CreditAttribution: izmeez commentedI would also suggest commit of #1153206: Full URI not passed to demo_admin_settings_validate prior to tagging a new release.
Comment #11
trillex CreditAttribution: trillex commentedI have, through the use of the release, just broken my site.
As I am a terrible person and rarely take backup of my sites before they launch, I am at a complete loss. The module have, however, created a dump, which, according to this issue, isn't working without a lot of manual work.
Now, if I was willing to put in this work to recreate the database, how would I go about doing that?
EDIT: Got it working after a lot of manual work. Essentially what's missing is all the information regarding the tables, so you'd have to create them manually or let Drupal do the work. Then it's pretty much just copy and paste the insert statement into your favourite SQL client.
Comment #12
izmeez CreditAttribution: izmeez commented@trillex Good news. Now that you have your data and a backup :-) would you consider testing the dev version?
Comment #13
Alan D. CreditAttribution: Alan D. commentedDev worked for me too.
I guess 'snapshots made with 1.0 will still be broken' would warrant it's own issue.
So this is actually fixed in dev, so nothing left in this thread to do, so it probably should be closed.
I have created #2505023: Time for new release of demo module, please. for the release request.
Comment #14
gaurav.kapoor CreditAttribution: gaurav.kapoor commented