all nodes listed as a teaser or full page shows

right before

the nodes do not have a

included.
even if the node type is not checked in admin > site conf > paging
does not make sense why

would be output.

unchecking paging in admin > site conf > input format >Filtered HTML makes the

go away.
of course, that turns off the paging feature.

test: drupal 5.2,php 5.2.2,apache 1.3.33, mysql 5.0.41 intel
production: drupal 5.2,php 4.4.6, apache 1.3.37

CommentFileSizeAuthor
#9 paging-DRUPAL-5.pagefilter.patch715 bytessun

Comments

dsp1’s picture

oops, did not think it needed the code tag.

all nodes listed as a teaser or full page shows <!--paging_filter--> right before <p>
the nodes do not have a <!--pagebreak-->
even if the node type is not checked in admin > site conf > paging they still show.
does not make sense why <!--paging_filter--> would be output.

unchecking paging in admin > site conf > input format >Filtered HTML makes the <!--paging_filter--> go away.
of course, that turns off the paging feature.

Gurpartap Singh’s picture

Category: bug » support
Status: Active » Fixed

<!--paging_filter--> is just a helper for paging functionality. <!--pagebreak--> is different from it, and is supposed to only indicate separation points, not to display in final content.

dnewkerk’s picture

Title: extra code added to html output » <!--paging_filter--> extra code added to html output

For other people's reference... I believe what was causing dsp1's issue was the order of the filters in his Input format. I was able to repeat the same results if the Paging filter did not come after the contributed HTML Corrector filter (it may also occur in relation to other filters as well, but this is the one I had personally that I identified as the clear culprit). However, HTML Corrector is in Drupal 6 core now as well, so this may be a more common occurrence once people begin using Drupal 6.

If the mysterious <!--paging_filter--> comes up printed into your page's output (which it could in the case of disabling and re-enabling other unrelated filters, since doing so can change the order that they previously were in), fortunately it's easy to fix. For the Filtered HTML input format (other input format paths will be a little different) go to: admin/settings/filters/1/order (the Rearrange tab) and set Paging to a weight of 10 (or any weight that ensures it remains below HTML Corrector (or whichever filters are causing the issue).

Note that I've added <!--paging_filter--> to this issue's title so that people with the same problem will be able to find it more easily.
Hope this helps.

dsp1’s picture

Title: <!--paging_filter--> extra code added to html output » <!--paging_filter--> code added to html output
Status: Fixed » Active

Keyz, thanks for the suggestion.

I set Smileys filter and Gallery2 filter to 9 and Paging to 10.
unfortunately <!--paging_filter--> is still being output to the final content. <!--paging_filter--> repeats on the front page for ever node listed.

I am not using the HTML Corrector filter.

drupal 5.3, gallery2 dev-2.x, Smiley 1.0

dnewkerk’s picture

dsp1... Can you attempt to disable all other non-core filters to see if any particular one of them is to blame? Also, please clear Drupal's cache... if you have Devel module you can do that easily through one of its menu items, or you can manually empty the appropriate mysql cache table if you prefer. I noticed last night that changes to input filters don't always "catch on" until I've cleared the cache.

dsp1’s picture

Keyz, I unchecked all filters including HTML filter except Paging filter.
and still <!--paging_filter--> repeats on the front page for every node.

dnewkerk’s picture

Hmm dsp1... not sure what to tell you. I tested to be sure in both 5.x-1.0 and 5.x-1.x-dev and didn't get the bug other than when I had the input formats in the wrong order (e.g. HTML filter or HTML Corrector after Paging in the Rearrange tab... if HTML filter was after Paging all I got was the effect of no paging - no extra code on the page... the code only appears for me when: HTML filter -> Paging -> HTML Corrector).

I would suggest testing, in this order:

  1. Set up the filters exactly right, Paging last (or all off but Paging), clear all of Drupal's caches (to be completely sure, if you have it use phpMyAdmin or your database manager and empty/truncate every table that has "cache" in the name... don't "delete" the table - just "empty" it), and edit a node that is exhibiting this behavior - make sure the <!--paging_filter--> code has not become embedded in your node's body field (not sure if this can happen, but if it were me I'd check for it, so just mentioning it). Save the node and see if anything changes.
  2. Fully reinstall the module. I haven't checked if 1.0 has one, but 1.x-dev has an uninstaller. First disable the module, then fully uninstall it. If you want to be extra thorough, do a search on your mysql tables for "paging" to see if anything comes up (careful, in this case Drupal's built-in paging might come up as well).
  3. Try switching back to 1.0 if you were using 1.x-dev.
  4. I'm not sure it would help me or anyone troubleshoot, but it might be a good idea to post your apache, php, and mysql versions, and anything else special about your server.

Hope this helps.

sun’s picture

Title: <!--paging_filter--> code added to html output » <!--paging_filter--> not removed from HTML output
Category: support » bug
Priority: Normal » Minor

If <!--paging_filter--> is displayed, then this issue is a duplicate of #97182: <!--break --> is transformed into html code with lt and gt.

If it just appears in the resulting HTML markup (as a comment), but isn't visible in the browser, then this issue is valid.
Paging module strips all instances of <!--pagebreak-->, but does not remove its helper tag <!--paging_filter-->.

sun’s picture

Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new715 bytes

Option 2) is true. Attached patch removes the comment from output.

Gurpartap Singh’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Fixed
Gurpartap Singh’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Fixed » Patch (to be ported)

Needs to be comitted to Drupal 5 branch.

sun’s picture

$GLOBALS['display_paging_block'] = TRUE;

Usage of global variables is not recommended. If there is really no other way, then the global needs to have a leading underscore and also start with the module's name to avoid module namespace issues.

BradM’s picture

Just FYI, in my setup, I had to have it filter for &lt;!--paging_filter--> (as in changing the first < to &lt;). I'm using the line break converter and html corrector, and paging is at the bottom.

Gurpartap Singh’s picture

Status: Patch (to be ported) » Fixed

<!--paging_filter--> is now stripped from the output in 5.x-1.x.

http://drupal.org/cvs?commit=166579

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alexkb’s picture

In the D6 version, I still seem to be getting this random '<!--paging_filter-->' html being inserted into the start of items when displaying them views (without any body text thats more then the pagining limit).

Has anyone else experienced this issue?

alexkb’s picture

Just to add to the above comment, I managed to get around this issue by having a field specific template file for the fields field:

views-view-field--body.tpl.php:
<?php print str_replace('&lt;!--paging_filter-->', '', $output); ?>

Hope that can help someone :)

mauryg’s picture

I posted the same issue as alexkb (#16 above) in node/433604 and then I found this thread. I followed the suggestion from Keyz (#7 above). I set the paging filter weight to 10 and all others above it and cleared the db cache tables using phpMyadmin. That got rid of the random <!--paging_filter--> instances and the paging is working. But now I am seeing <!--break--> in all the places where I put a teaser break. Curioser and curiouser.

MOVED TO #433604