Hi, I just met a problem about the displays.
Every time I add a new display to a views, the default display will be changed. When I say 'changed', I mean there'll be an asterisk attached to the default diaplay's name.
The default display could be any existing display inside the views. Saying there're 5 displays in this views, when I open this views' edit page, the default display will be the first one. Then I click any other display, the default display will be changed to the one I just clicked. While I add a new display, maybe a block display or page display, an asterisk will appear in the default display's name.
I'm pretty sure all the fields in each display have been set overridden. So will this bring any potential problems? Thank you.

CommentFileSizeAuthor
#4 views-1793992-test-only.patch1.17 KBdawehner
#4 views-1793992-4.patch1.78 KBdawehner
#1 views-1793992-1.patch599 bytesdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.1 » 8.x-3.x-dev
Category: support » bug
Priority: Normal » Minor
Status: Active » Needs review
Issue tags: +Needs tests, +VDC
FileSize
views-1793992-1.patch599 bytes

Well this is just a bug in the marking of changed displays.

If you add a new display, always the current active display get marked as changed, even there haven't been one.

The tests are somehow blocked by #1793690: Reorder display doesn't work

smiletrl’s picture

smiletrl CreditAttribution: smiletrl commented

Hi dawehner,
Thank you for your replay. since it's a bug and not going to cause problems, I guess I'm ok with that. Thanks for your patch.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

not blocked anymore

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
views-1793992-4.patch1.78 KB
views-1793992-test-only.patch1.17 KB

Rerolled the actual patch and post one test-only patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » dawehner 
+++ b/lib/Drupal/views/ViewUI.phpundefined
@@ -789,6 +789,9 @@ class ViewUI extends ViewExecutable {
+    // A new display got added so the asteriks symbol should appear on the new

You're missing the extra 's' in asterisks. Otherwise, RTBC. Can fix before commit.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: dawehner » Unassigned
Status: Needs review » Patch (to be ported)

Ah yeah this word looks ugly without that. Committed and pushed.