I was approached by someone to create a Stroke effect (adding a border around an image) and thought I would contribute the code to the project. This is my first code contribution and first time using git, so please bear with me as I come to terms with the technology.

CommentFileSizeAuthor
#1 imagecache_actions-Add.stroke.effect.to_.Imagecache.Actions-1054616-1.patch4.46 KBel_toro

Comments

el_toro’s picture

el_toro commented
StatusFileSize
new imagecache_actions-Add.stroke.effect.to_.Imagecache.Actions-1054616-1.patch4.46 KB

Here's the patch, hope it was done correctly.

el_toro’s picture

el_toro commented
Status: Active » Needs review
fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented

After a quick look at the code, this seems like the "Define canvas" effect to me. Please correct me if I'm wrong.

el_toro’s picture

el_toro commented

I guess the same could be achieved using Define Canvas. But, I do think Define Canvas is kinda overkill if all you want is a border around an image.

fietserwin’s picture

fietserwin
Location Le Mont-Dore
commented
Status: Needs review » Closed (won't fix)

Probably, but so is maintaining, documenting, porting and supporting effects that are specified as a subset of more powerful andmore generic commands. We also have a UX problem here as the drop down llist gets longer and longer with no sorting/grouping at all.