Spelling suggestions weren't showing up for me in RC4. I tracked it down to a what is probably a refactoring bug. Patch attached.

CommentFileSizeAuthor
#5 1793610-5-D6.patch676 bytespwolanin
apachesolr-search-spelling-suggestions-missing.patch676 byteszengenuity

Comments

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

doh - well, before we add this, we should have some simpletest that actually tests this functionality. Or should we roll another RC as this is quite critical and have a follow-up issue?

steve.colson’s picture

steve.colson commented
Status: Active » Reviewed & tested by the community

Sitting in on Wayne's DUG presentation on solr--good catch on this!

I think re-roll and then write the simpletest. Certainly in our use case, we would have likely ran drush up and not noticed spelling was broken. Better to give people a quick upgrade path than to prevent it from regressing again in the future.

pwolanin’s picture

pwolanin commented

We should figure out at least a minimal regression test for this?

pwolanin’s picture

pwolanin commented
Version: 7.x-1.0-rc4 » 6.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

committed to 7.x

pwolanin’s picture

pwolanin commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1793610-5-D6.patch676 bytes
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)
justluvgod’s picture

justluvgod commented
justluvgod’s picture

justluvgod commented

the spelling suggestion doesn't work for me using

Drupal 7,21
Apache Solr search - 7.x-1.2+2-dev

My highlighting doesn't work either. I get initialized term words.

justluvgod’s picture

justluvgod commented

I just installed the latest dev version of Apache solr integration (7.x-1.x-dev) dated may 16th and the following now works.

The "did you mean now" appears
The highlighting now works (see you changed tag from em to strong) after search