Description keys were removed from the schema cache in Drupal 7. This broke the describe tab which no longer shows any descriptions for tables and fields.

Proposed solution is to get the full schema including descriptions without using drupal_get_schema().

CommentFileSizeAuthor
#7 1792608-schema-missing-descriptions_7.patch4.44 KBgreggles
#3 1792608-schema-missing-descriptions.patch4.46 KBDave Reid
#1 schema-construct-schema-manually-1792608-1.patch702 bytesAntti J. Salminen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Antti J. Salminen’s picture

Antti J. Salminen CreditAttribution: Antti J. Salminen commented
Status: Active » Needs review
FileSize
schema-construct-schema-manually-1792608-1.patch702 bytes

Here's an attached patch that removes drupal_get_schema() usage and constructs the schema in a way similar to what drupal_get_complete_schema() does.

jneubert’s picture

jneubert CreditAttribution: jneubert commented

Worked fine for me - thanks!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Issue summary: View changes
FileSize
1792608-schema-missing-descriptions.patch4.46 KB

Moved this to a re-usable function that could be used by all.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented

The comment before the call to _drupal_schema_initialize() needs to be updated.

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented

This could also be fixed by #2369097: Allow descriptions to be returned by drupal_get_schema().

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland commented
Related issues: +#2369097: Allow descriptions to be returned by drupal_get_schema()
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Status: Needs review » Reviewed & tested by the community
FileSize
1792608-schema-missing-descriptions_7.patch4.44 KB

I've rerolled this to updated the comment as suggested by Liam Morland, but it's basically the same as Dave's work.

Moving to RTBC since I only changed the comment.

I also noticed some other issues in the queue that seem to be related and/or dups of this issue, so it seems worthwhile to commit and release soon.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented
Priority: Normal » Major

IMO this is at least major since it affects a pretty basic use of the module.

  • joachim committed 0986c68 on 7.x-1.x authored by Dave Reid 
    Issue #1792608 by Antti J. Salminen, greggles, Dave Reid: Fixed table...
joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Thanks for the reroll!

Committed.

joachim’s picture

joachim CreditAttribution: joachim as a volunteer commented

This warrants a new release (though it's clearly been broken for ages!). I'll check the issue queue for any low-hanging fruit and make a new release soon.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
CreditAttribution: greggles at CARD.com commented

Agreed about a new release. Thanks for your recent work on this module!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.