See #1790752: Set Apache Solr Search Integration to be the default search on install

CommentFileSizeAuthor
#18 1791442-17.patch19.09 KBNick_vh
#12 1791442-12.patch3.16 KBNick_vh
#8 set-default-search-1791442-8.patch3.16 KBcpliakas
#6 1791442-6.patch747 bytesNick_vh
#3 1791442-1.patch516 bytesNick_vh
#1 set-default-search-1791442-1.patch682 bytescpliakas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Active » Needs review
FileSize
set-default-search-1791442-1.patch682 bytes

The attached patch makes the suggested change. Marking as "needs work" pending SimpleTests.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs review » Needs work

Really marking as needs work.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Needs work » Needs review
FileSize
1791442-1.patch516 bytes
Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented

Worked as expected in manual test

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented

Hmm drupal.org did weird, i missed completely Chris's posts

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
FileSize
1791442-6.patch747 bytes

I agree with the place of this variable-set, so it only happens once when we enable/recreate the environment

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs review » Needs work

Marking as needs work pending tests. I have the tests working, so give me a minute to post.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs work » Needs review
FileSize
set-default-search-1791442-8.patch3.16 KB

Patch with tests.

Status: Needs review » Needs work

The last submitted patch, set-default-search-1791442-8.patch, failed testing.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Needs work » Needs review

#8: set-default-search-1791442-8.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, set-default-search-1791442-8.patch, failed testing.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
FileSize
1791442-12.patch3.16 KB

Just re-rolled it

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1791442-12.patch, failed testing.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented

Looks like the testbot fails here?

I'm ok in committing this change if local tests succeed

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

We have line ending issues in the Acquia Search module. Ugh. Tests pass locally, let's fix the line endings.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Needs work » Reviewed & tested by the community

So yes, I say commit and then let's post an issue to fix the line ending issues.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Reviewed & tested by the community » Needs review
FileSize
1791442-17.patch19.09 KB

ugh, only way to fix is like this it seems (It was windows and now back to linux)

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Project: Acquia Connector » Acquia Search
Version: 7.x-2.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed!

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Patch (to be ported) » Fixed

not applicable for 6.x-3.x

pwolanin’s picture

pwolanin CreditAttribution: pwolanin commented
Project: Acquia Search » Acquia Connector
Version: 6.x-3.x-dev » 7.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.