See #1790752: Set Apache Solr Search Integration to be the default search on install

CommentFileSizeAuthor
#18 1791442-17.patch19.09 KBnick_vh
#12 1791442-12.patch3.16 KBnick_vh
#8 set-default-search-1791442-8.patch3.16 KBcpliakas
#6 1791442-6.patch747 bytesnick_vh
#3 1791442-1.patch516 bytesnick_vh
#1 set-default-search-1791442-1.patch682 bytescpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new set-default-search-1791442-1.patch682 bytes

The attached patch makes the suggested change. Marking as "needs work" pending SimpleTests.

cpliakas’s picture

cpliakas commented
Status: Needs review » Needs work

Really marking as needs work.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Needs review
StatusFileSize
new 1791442-1.patch516 bytes
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Worked as expected in manual test

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Hmm drupal.org did weird, i missed completely Chris's posts

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1791442-6.patch747 bytes

I agree with the place of this variable-set, so it only happens once when we enable/recreate the environment

cpliakas’s picture

cpliakas commented
Status: Needs review » Needs work

Marking as needs work pending tests. I have the tests working, so give me a minute to post.

cpliakas’s picture

cpliakas commented
Status: Needs work » Needs review
StatusFileSize
new set-default-search-1791442-8.patch3.16 KB

Patch with tests.

Status: Needs review » Needs work

The last submitted patch, set-default-search-1791442-8.patch, failed testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Needs review

#8: set-default-search-1791442-8.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, set-default-search-1791442-8.patch, failed testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1791442-12.patch3.16 KB

Just re-rolled it

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1791442-12.patch, failed testing.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Looks like the testbot fails here?

I'm ok in committing this change if local tests succeed

cpliakas’s picture

cpliakas commented

We have line ending issues in the Acquia Search module. Ugh. Tests pass locally, let's fix the line endings.

cpliakas’s picture

cpliakas commented
Status: Needs work » Reviewed & tested by the community

So yes, I say commit and then let's post an issue to fix the line ending issues.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 1791442-17.patch19.09 KB

ugh, only way to fix is like this it seems (It was windows and now back to linux)

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Project: Acquia Connector » Acquia Search
Version: 7.x-2.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Committed!

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Patch (to be ported) » Fixed

not applicable for 6.x-3.x

pwolanin’s picture

pwolanin commented
Project: Acquia Search » Acquia Connector
Version: 6.x-3.x-dev » 7.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.